fix(slack): remove duplicate effect that cleared subblocks on cred change#2788
fix(slack): remove duplicate effect that cleared subblocks on cred change#2788waleedlatif1 merged 1 commit intostagingfrom
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub. |
Greptile OverviewGreptile SummaryThis PR removes a What changed:
Why this is a duplicate:
The removed logic was overly aggressive - it cleared ALL subblocks except Confidence Score: 5/5
Important Files ChangedFile Analysis
Sequence DiagramsequenceDiagram
participant User
participant WorkflowBlock
participant CredentialSelector
participant SubBlockStore
Note over WorkflowBlock: Before this PR
User->>CredentialSelector: Change credential
CredentialSelector->>SubBlockStore: Update credential value
WorkflowBlock->>SubBlockStore: Detect credential change
WorkflowBlock->>SubBlockStore: Clear ALL dependent fields
Note over WorkflowBlock: Problem: Duplicate clearing logic
Note over WorkflowBlock: After this PR
User->>CredentialSelector: Change credential
CredentialSelector->>SubBlockStore: Update credential value
Note over CredentialSelector: Handles clearing internally
Note over WorkflowBlock: No longer involved in clearing
|
Summary
remove duplicate effect that cleared subblocks on cred change
Type of Change
Testing
Tested manually
Checklist