fix(subflow): updated subflow border to match block border#2768
fix(subflow): updated subflow border to match block border#2768waleedlatif1 merged 1 commit intostagingfrom
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub. |
Greptile OverviewGreptile SummaryThis PR updates subflow borders to use Changes Made
What This AchievesIn light mode, Incomplete UpdateThe header divider border (border-b) was not updated and still uses Confidence Score: 4/5
Important Files ChangedFile Analysis
Sequence DiagramsequenceDiagram
participant Dev as Developer
participant SubflowNode as SubflowNode Component
participant PreviewSubflow as Preview Subflow
participant CSS as CSS Variables
Dev->>SubflowNode: Change border to --border-1
SubflowNode->>CSS: Request --border-1 value
CSS-->>SubflowNode: Light: #e0e0e0, Dark: #3d3d3d
Dev->>PreviewSubflow: Change border to --border-1
PreviewSubflow->>CSS: Request --border-1 value
CSS-->>PreviewSubflow: Light: #e0e0e0, Dark: #3d3d3d
Note over SubflowNode,PreviewSubflow: Header border still uses --border
SubflowNode->>CSS: Request --border (header)
CSS-->>SubflowNode: Light: #e0e0e0, Dark: #2c2c2c
PreviewSubflow->>CSS: Request --border (header)
CSS-->>PreviewSubflow: Light: #e0e0e0, Dark: #2c2c2c
Note over SubflowNode,PreviewSubflow: Dark mode: Border mismatch<br/>(#3d3d3d vs #2c2c2c)
|
Additional Comments (2)
For consistency with workflow-block.tsx (line 990), this should also use Note: If this suggestion doesn't match your team's coding style, reply to this and let me know. I'll remember it for next time! Prompt To Fix With AIThis is a comment left during a code review.
Path: apps/sim/app/workspace/[workspaceId]/w/[workflowId]/components/subflows/subflow-node.tsx
Line: 169:169
Comment:
The header border-b uses `border-[var(--border)]` while the main container border now uses `border-[var(--border-1)]`. In dark mode, these have different values (#2c2c2c vs #3d3d3d), creating a visual inconsistency where the header border will appear lighter than the main border.
For consistency with workflow-block.tsx (line 990), this should also use `--border-1`:
```suggestion
'workflow-drag-handle flex cursor-grab items-center justify-between rounded-t-[8px] border-[var(--border-1)] border-b bg-[var(--surface-2)] py-[8px] pr-[12px] pl-[8px] [&:active]:cursor-grabbing'
```
<sub>Note: If this suggestion doesn't match your team's coding style, reply to this and let me know. I'll remember it for next time!</sub>
How can I resolve this? If you propose a fix, please make it concise.
For consistency, this should also use Note: If this suggestion doesn't match your team's coding style, reply to this and let me know. I'll remember it for next time! Prompt To Fix With AIThis is a comment left during a code review.
Path: apps/sim/app/workspace/[workspaceId]/w/components/preview/components/subflow.tsx
Line: 66:66
Comment:
The header border-b uses `border-[var(--border)]` while the main container border now uses `border-[var(--border-1)]`. In dark mode, these have different values (#2c2c2c vs #3d3d3d), creating a visual inconsistency where the header border will appear lighter than the main border.
For consistency, this should also use `--border-1`:
```suggestion
<div className='flex items-center justify-between rounded-t-[8px] border-[var(--border-1)] border-b bg-[var(--surface-2)] py-[8px] pr-[12px] pl-[8px]'>
```
<sub>Note: If this suggestion doesn't match your team's coding style, reply to this and let me know. I'll remember it for next time!</sub>
How can I resolve this? If you propose a fix, please make it concise. |
Summary
Type of Change
Testing
N/A
Checklist