improvement(variables): update workflows to use deployed variables, not local ones to align with the rest of the canvas components#2577
Merged
waleedlatif1 merged 2 commits intostagingfrom Dec 25, 2025
Conversation
…ot local ones to align with the rest of the canvas components
…data and not actually required to be redeployed
|
The latest updates on your projects. Learn more about Vercel for GitHub. |
Contributor
Greptile SummaryThis PR aligns workflow execution behavior with other canvas components by using deployed variables instead of local ones, and fixes false-positive change detection for integration triggers. Key Changes:
Technical Implementation:
Confidence Score: 5/5
Important Files Changed
Sequence DiagramsequenceDiagram
participant Client as Client (Canvas)
participant ChangeDetection as useChangeDetection Hook
participant VariablesStore as Variables Store
participant DeployAPI as Deploy API
participant StatusAPI as Status API
participant ExecuteAPI as Execute API
participant DB as Database
participant DeploymentVersion as Deployment Version Table
Note over Client,DB: Change Detection Flow
Client->>VariablesStore: Get workflow variables
VariablesStore-->>ChangeDetection: Return variables filtered by workflowId
Client->>ChangeDetection: Detect changes (blocks, edges, loops, parallels, variables)
ChangeDetection->>ChangeDetection: Build currentState with variables
ChangeDetection->>ChangeDetection: Compare with deployedState (hasWorkflowChanged)
Note over ChangeDetection: Excludes trigger runtime metadata<br/>(webhookId, triggerPath, testUrl, testUrlExpiresAt)
ChangeDetection-->>Client: Return changeDetected flag
Note over Client,DB: Deployment Flow
Client->>DeployAPI: POST /api/workflows/{id}/deploy
DeployAPI->>DB: Load workflow from normalized tables
DeployAPI->>DB: Fetch workflow.variables
DeployAPI->>DeployAPI: Build currentState with variables
DeployAPI->>DeploymentVersion: Create deployment version with state + variables
DeployAPI-->>Client: Return deployment success
Note over Client,DB: Status Check Flow
Client->>StatusAPI: GET /api/workflows/{id}/status
StatusAPI->>DB: Load workflow from normalized tables
StatusAPI->>DB: Fetch workflow.variables
StatusAPI->>StatusAPI: Build currentState with variables
StatusAPI->>StatusAPI: Compare with deployed state
StatusAPI-->>Client: Return needsRedeployment flag
Note over Client,DB: Execution Flow
Client->>ExecuteAPI: POST /api/workflows/{id}/execute
ExecuteAPI->>DeploymentVersion: Load deployed workflow state
DeploymentVersion-->>ExecuteAPI: Return state with variables
ExecuteAPI->>ExecuteAPI: Use deployedVariables (not local workflow.variables)
ExecuteAPI->>ExecuteAPI: Create ExecutionSnapshot with deployedVariables
ExecuteAPI-->>Client: Stream execution with deployed variables
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Type of Change
Testing
Tested manually
Checklist