simplify event

icecrasher321 · icecrasher321 · commit b28b2a34ce26 · 2026-04-14T15:13:05.000-07:00
diff --git a/apps/sim/app/api/copilot/chat/delete/route.test.ts b/apps/sim/app/api/copilot/chat/delete/route.test.ts
@@ -41,7 +41,7 @@ vi.mock('@/lib/copilot/chat/lifecycle', () => ({
 }))
 
 vi.mock('@/lib/copilot/tasks', () => ({
-  taskPubSub: { publishStatusChanged: vi.fn() },
+  taskPubSub: { publishTaskListChanged: vi.fn() },
 }))
 
 import { DELETE } from './route'
diff --git a/apps/sim/app/api/copilot/chat/delete/route.ts b/apps/sim/app/api/copilot/chat/delete/route.ts
@@ -41,10 +41,8 @@ export async function DELETE(request: NextRequest) {
     logger.info('Chat deleted', { chatId: parsed.chatId })
 
     if (deleted.workspaceId) {
-      taskPubSub?.publishStatusChanged({
+      taskPubSub?.publishTaskListChanged({
         workspaceId: deleted.workspaceId,
-        chatId: parsed.chatId,
-        type: 'deleted',
       })
     }
 
diff --git a/apps/sim/app/api/copilot/chat/rename/route.ts b/apps/sim/app/api/copilot/chat/rename/route.ts
@@ -44,10 +44,8 @@ export async function PATCH(request: NextRequest) {
     logger.info('Chat renamed', { chatId, title })
 
     if (updated.workspaceId) {
-      taskPubSub?.publishStatusChanged({
+      taskPubSub?.publishTaskListChanged({
         workspaceId: updated.workspaceId,
-        chatId,
-        type: 'renamed',
       })
     }
 
diff --git a/apps/sim/app/api/copilot/chat/stop/route.ts b/apps/sim/app/api/copilot/chat/stop/route.ts
@@ -126,10 +126,8 @@ export async function POST(req: NextRequest) {
       .returning({ workspaceId: copilotChats.workspaceId })
 
     if (updated?.workspaceId) {
-      taskPubSub?.publishStatusChanged({
+      taskPubSub?.publishTaskListChanged({
         workspaceId: updated.workspaceId,
-        chatId,
-        type: 'completed',
       })
     }
 
diff --git a/apps/sim/app/api/copilot/chats/route.ts b/apps/sim/app/api/copilot/chats/route.ts
@@ -128,7 +128,7 @@ export async function POST(request: NextRequest) {
       return createInternalServerErrorResponse('Failed to create chat')
     }
 
-    taskPubSub?.publishStatusChanged({ workspaceId, chatId: result.chatId, type: 'created' })
+    taskPubSub?.publishTaskListChanged({ workspaceId })
 
     return NextResponse.json({ success: true, id: result.chatId })
   } catch (error) {
diff --git a/apps/sim/app/api/mothership/chats/[chatId]/route.ts b/apps/sim/app/api/mothership/chats/[chatId]/route.ts
@@ -165,10 +165,8 @@ export async function PATCH(
 
     if (updatedChat.workspaceId) {
       if (title !== undefined) {
-        taskPubSub?.publishStatusChanged({
+        taskPubSub?.publishTaskListChanged({
           workspaceId: updatedChat.workspaceId,
-          chatId,
-          type: 'renamed',
         })
         captureServerEvent(
           userId,
@@ -239,10 +237,8 @@ export async function DELETE(
     }
 
     if (deletedChat.workspaceId) {
-      taskPubSub?.publishStatusChanged({
+      taskPubSub?.publishTaskListChanged({
         workspaceId: deletedChat.workspaceId,
-        chatId,
-        type: 'deleted',
       })
       captureServerEvent(
         userId,
diff --git a/apps/sim/app/api/mothership/chats/route.ts b/apps/sim/app/api/mothership/chats/route.ts
@@ -94,7 +94,7 @@ export async function POST(request: NextRequest) {
       })
       .returning({ id: copilotChats.id })
 
-    taskPubSub?.publishStatusChanged({ workspaceId, chatId: chat.id, type: 'created' })
+    taskPubSub?.publishTaskListChanged({ workspaceId })
 
     captureServerEvent(
       userId,
diff --git a/apps/sim/app/api/mothership/events/route.ts b/apps/sim/app/api/mothership/events/route.ts
@@ -1,8 +1,8 @@
 /**
  * SSE endpoint for task status events.
  *
- * Pushes `task_status` events to the browser when tasks are
- * started, completed, created, deleted, or renamed.
+ * Pushes `task_status` events to the browser when the workspace task list
+ * changes.
  *
  * Auth is handled via session cookies (EventSource sends cookies automatically).
  */
@@ -18,13 +18,9 @@ export const GET = createWorkspaceSSE({
     {
       subscribe: (workspaceId, send) => {
         if (!taskPubSub) return () => {}
-        return taskPubSub.onStatusChanged((event) => {
+        return taskPubSub.onTaskListChanged((event) => {
           if (event.workspaceId !== workspaceId) return
-          send('task_status', {
-            chatId: event.chatId,
-            type: event.type,
-            timestamp: Date.now(),
-          })
+          send('task_status', {})
         })
       },
     },
diff --git a/apps/sim/lib/copilot/chat/post.test.ts b/apps/sim/lib/copilot/chat/post.test.ts
@@ -84,7 +84,7 @@ vi.mock('@/lib/copilot/chat/lifecycle', () => ({
 
 vi.mock('@/lib/copilot/tasks', () => ({
   taskPubSub: {
-    publishStatusChanged: vi.fn(),
+    publishTaskListChanged: vi.fn(),
   },
 }))
 
diff --git a/apps/sim/lib/copilot/chat/post.ts b/apps/sim/lib/copilot/chat/post.ts
@@ -284,7 +284,7 @@ async function persistUserMessage(params: {
     .returning({ messages: copilotChats.messages })
 
   if (notifyWorkspaceStatus && updated && workspaceId) {
-    taskPubSub?.publishStatusChanged({ workspaceId, chatId, type: 'started' })
+    taskPubSub?.publishTaskListChanged({ workspaceId })
   }
 
   return Array.isArray(updated?.messages) ? updated.messages : undefined
@@ -348,11 +348,7 @@ function buildOnComplete(params: {
       })
 
       if (notifyWorkspaceStatus && workspaceId) {
-        taskPubSub?.publishStatusChanged({
-          workspaceId,
-          chatId,
-          type: 'completed',
-        })
+        taskPubSub?.publishTaskListChanged({ workspaceId })
       }
     } catch (error) {
       logger.error(`[${requestId}] Failed to persist chat messages`, {
@@ -379,11 +375,7 @@ function buildOnError(params: {
       await finalizeAssistantTurn({ chatId, userMessageId })
 
       if (notifyWorkspaceStatus && workspaceId) {
-        taskPubSub?.publishStatusChanged({
-          workspaceId,
-          chatId,
-          type: 'completed',
-        })
+        taskPubSub?.publishTaskListChanged({ workspaceId })
       }
     } catch (error) {
       logger.error(`[${requestId}] Failed to finalize errored chat stream`, {
diff --git a/apps/sim/lib/copilot/request/lifecycle/start.ts b/apps/sim/lib/copilot/request/lifecycle/start.ts
@@ -269,7 +269,7 @@ function fireTitleGeneration(params: {
         payload: { kind: MothershipStreamV1SessionKind.title, title },
       })
       if (workspaceId) {
-        taskPubSub?.publishStatusChanged({ workspaceId, chatId, type: 'renamed' })
+        taskPubSub?.publishTaskListChanged({ workspaceId })
       }
     })
     .catch((error) => {
diff --git a/apps/sim/lib/copilot/tasks.ts b/apps/sim/lib/copilot/tasks.ts
@@ -1,29 +1,29 @@
 /**
- * Task Status Pub/Sub Adapter
+ * Task List Change Pub/Sub Adapter
  *
- * Broadcasts task status events across processes using Redis Pub/Sub.
- * Gracefully falls back to process-local EventEmitter when Redis is unavailable.
+ * Broadcasts workspace-scoped task list change notifications across processes
+ * using Redis Pub/Sub. Gracefully falls back to a process-local EventEmitter
+ * when Redis is unavailable.
  *
  * Channel: `task:status_changed`
  */
 
 import { createPubSubChannel } from '@/lib/events/pubsub'
 
-interface TaskStatusEvent {
+interface TaskListChangedEvent {
   workspaceId: string
-  chatId: string
-  type: 'started' | 'completed' | 'created' | 'deleted' | 'renamed'
 }
 
 const channel =
   typeof window !== 'undefined'
     ? null
-    : createPubSubChannel<TaskStatusEvent>({ channel: 'task:status_changed', label: 'task' })
+    : createPubSubChannel<TaskListChangedEvent>({ channel: 'task:status_changed', label: 'task' })
 
 export const taskPubSub = channel
   ? {
-      publishStatusChanged: (event: TaskStatusEvent) => channel.publish(event),
-      onStatusChanged: (handler: (event: TaskStatusEvent) => void) => channel.subscribe(handler),
+      publishTaskListChanged: (event: TaskListChangedEvent) => channel.publish(event),
+      onTaskListChanged: (handler: (event: TaskListChangedEvent) => void) =>
+        channel.subscribe(handler),
       dispose: () => channel.dispose(),
     }
   : null
diff --git a/apps/sim/lib/mothership/inbox/executor.ts b/apps/sim/lib/mothership/inbox/executor.ts
@@ -113,29 +113,23 @@ export async function executeInboxTask(taskId: string): Promise<void> {
         .then(async (title) => {
           if (title && chatId) {
             await db.update(copilotChats).set({ title }).where(eq(copilotChats.id, chatId))
-            taskPubSub?.publishStatusChanged({
+            taskPubSub?.publishTaskListChanged({
               workspaceId: ws.id,
-              chatId,
-              type: 'renamed',
             })
           }
         })
         .catch((err) => {
           logger.warn('Failed to generate chat title', { chatId, err })
         })
 
-      taskPubSub?.publishStatusChanged({
+      taskPubSub?.publishTaskListChanged({
         workspaceId: ws.id,
-        chatId,
-        type: 'created',
       })
     }
 
     if (chatId) {
-      taskPubSub?.publishStatusChanged({
+      taskPubSub?.publishTaskListChanged({
         workspaceId: ws.id,
-        chatId,
-        type: 'started',
       })
     }
 
@@ -240,10 +234,8 @@ export async function executeInboxTask(taskId: string): Promise<void> {
       .where(eq(mothershipInboxTask.id, taskId))
 
     if (chatId) {
-      taskPubSub?.publishStatusChanged({
+      taskPubSub?.publishTaskListChanged({
         workspaceId: ws.id,
-        chatId,
-        type: 'completed',
       })
     }
 

Original file line number	Diff line number	Diff line change
`@@ -128,7 +128,7 @@ export async function POST(request: NextRequest) {`
`128`	`128`	`return createInternalServerErrorResponse('Failed to create chat')`
`129`	`129`	`}`
`130`	`130`
`131`		`- taskPubSub?.publishStatusChanged({ workspaceId, chatId: result.chatId, type: 'created' })`
	`131`	`+ taskPubSub?.publishTaskListChanged({ workspaceId })`
`132`	`132`
`133`	`133`	`return NextResponse.json({ success: true, id: result.chatId })`
`134`	`134`	`} catch (error) {`