fix(refetch): task sse terminal event removed and auto-refetch behaviour disabled

Author: icecrasher321

apps/sim/app/workspace/[workspaceId]/home/hooks/use-chat.ts

@@ -2622,16 +2622,30 @@ export function useChat(
     []
   )
 
-  const invalidateChatQueries = useCallback(() => {
-    const activeChatId = chatIdRef.current
-    if (activeChatId) {
+  const invalidateTaskHistory = useCallback(
+    (refetchType: 'active' | 'none' = 'active') => {
+      const activeChatId = chatIdRef.current
+      if (!activeChatId) {
+        return
+      }
+
       queryClient.invalidateQueries({
         queryKey: taskKeys.detail(activeChatId),
+        refetchType,
       })
-    }
+    },
+    [queryClient]
+  )
+
+  const invalidateTaskList = useCallback(() => {
     queryClient.invalidateQueries({ queryKey: taskKeys.list(workspaceId) })
   }, [workspaceId, queryClient])
 
+  const invalidateChatQueries = useCallback(() => {
+    invalidateTaskHistory()
+    invalidateTaskList()
+  }, [invalidateTaskHistory, invalidateTaskList])
+
   const messagesRef = useRef(messages)
   messagesRef.current = messages
 
@@ -2643,7 +2657,8 @@ export function useChat(
       clearActiveTurn()
       setTransportIdle()
       abortControllerRef.current = null
-      invalidateChatQueries()
+      invalidateTaskHistory('none')
+      invalidateTaskList()
 
       if (!options?.error) {
         const cid = chatIdRef.current
@@ -2660,7 +2675,13 @@ export function useChat(
         void enqueueQueueDispatchRef.current({ type: 'send_head' })
       }
     },
-    [clearActiveTurn, invalidateChatQueries, reconcileTerminalPreviewSessions, setTransportIdle]
+    [
+      clearActiveTurn,
+      invalidateTaskHistory,
+      invalidateTaskList,
+      reconcileTerminalPreviewSessions,
+      setTransportIdle,
+    ]
   )
   finalizeRef.current = finalize
 

apps/sim/hooks/use-task-events.test.ts

@@ -16,44 +16,8 @@ describe('handleTaskStatusEvent', () => {
     vi.clearAllMocks()
   })
 
-  it('invalidates the task list and completed chat detail', () => {
-    handleTaskStatusEvent(
-      queryClient,
-      JSON.stringify({
-        chatId: 'chat-1',
-        type: 'completed',
-        timestamp: Date.now(),
-      })
-    )
-
-    expect(queryClient.invalidateQueries).toHaveBeenCalledTimes(2)
-    expect(queryClient.invalidateQueries).toHaveBeenNthCalledWith(1, {
-      queryKey: taskKeys.lists(),
-    })
-    expect(queryClient.invalidateQueries).toHaveBeenNthCalledWith(2, {
-      queryKey: taskKeys.detail('chat-1'),
-    })
-  })
-
-  it('keeps list invalidation only for non-completed task events', () => {
-    handleTaskStatusEvent(
-      queryClient,
-      JSON.stringify({
-        chatId: 'chat-1',
-        type: 'started',
-        timestamp: Date.now(),
-      })
-    )
-
-    expect(queryClient.invalidateQueries).toHaveBeenCalledTimes(1)
-    expect(queryClient.invalidateQueries).toHaveBeenCalledWith({
-      queryKey: taskKeys.lists(),
-    })
-  })
-
-  it('preserves list invalidation when task event payload is invalid', () => {
-    handleTaskStatusEvent(queryClient, '{')
-
+  it('invalidates the task list for task status updates', () => {
+    handleTaskStatusEvent(queryClient)
     expect(queryClient.invalidateQueries).toHaveBeenCalledTimes(1)
     expect(queryClient.invalidateQueries).toHaveBeenCalledWith({
       queryKey: taskKeys.lists(),

apps/sim/hooks/use-task-events.ts

@@ -6,55 +6,12 @@ import { taskKeys } from '@/hooks/queries/tasks'
 
 const logger = createLogger('TaskEvents')
 
-interface TaskStatusEventPayload {
-  chatId?: string
-  type?: 'started' | 'completed' | 'created' | 'deleted' | 'renamed'
-}
-
-function parseTaskStatusEventPayload(data: unknown): TaskStatusEventPayload | null {
-  let parsed = data
-
-  if (typeof parsed === 'string') {
-    try {
-      parsed = JSON.parse(parsed)
-    } catch {
-      return null
-    }
-  }
-
-  if (!parsed || typeof parsed !== 'object' || Array.isArray(parsed)) {
-    return null
-  }
-
-  const record = parsed as Record<string, unknown>
-
-  return {
-    ...(typeof record.chatId === 'string' ? { chatId: record.chatId } : {}),
-    ...(typeof record.type === 'string'
-      ? { type: record.type as TaskStatusEventPayload['type'] }
-      : {}),
-  }
-}
-
-export function handleTaskStatusEvent(
-  queryClient: Pick<QueryClient, 'invalidateQueries'>,
-  data: unknown
-): void {
+export function handleTaskStatusEvent(queryClient: Pick<QueryClient, 'invalidateQueries'>): void {
   queryClient.invalidateQueries({ queryKey: taskKeys.lists() })
-
-  const payload = parseTaskStatusEventPayload(data)
-  if (!payload) {
-    logger.warn('Received invalid task_status payload')
-    return
-  }
-
-  if (payload.type === 'completed' && payload.chatId) {
-    queryClient.invalidateQueries({ queryKey: taskKeys.detail(payload.chatId) })
-  }
 }
 
 /**
- * Subscribes to task status SSE events and invalidates task caches on changes.
+ * Subscribes to task status SSE events and refreshes the task list on changes.
  */
 export function useTaskEvents(workspaceId: string | undefined) {
   const queryClient = useQueryClient()
@@ -66,8 +23,8 @@ export function useTaskEvents(workspaceId: string | undefined) {
       `/api/mothership/events?workspaceId=${encodeURIComponent(workspaceId)}`
     )
 
-    eventSource.addEventListener('task_status', (event) => {
-      handleTaskStatusEvent(queryClient, event instanceof MessageEvent ? event.data : undefined)
+    eventSource.addEventListener('task_status', () => {
+      handleTaskStatusEvent(queryClient)
     })
 
     eventSource.onerror = () => {