fix(uploads): address PR review — abort propagation, orphan cleanup, error handling

- Throw immediately on AbortError in KB retry loop (no useless 14s backoff)
- Cleanup S3/Blob object on quota or size-cap rejection in registerUploadedWorkspaceFile
- Enforce MAX_WORKSPACE_FILE_SIZE at registration (defense vs presigned PUT lying about size)
- Handle non-OK / non-JSON responses in workspace-files upload paths

Author: waleedlatif1

apps/sim/app/workspace/[workspaceId]/knowledge/hooks/use-knowledge-upload.ts

@@ -259,7 +259,7 @@ export function useKnowledgeUpload(options: UseKnowledgeUploadOptions = {}) {
           return buildUploadedFile(file, toAbsoluteUrl(filePath))
         }
 
-        if (attempt >= MULTIPART_MAX_RETRIES || (!isNetworkError(error) && !isAbortError(error))) {
+        if (isAbortError(error) || !isNetworkError(error) || attempt >= MULTIPART_MAX_RETRIES) {
           throw error
         }
 

apps/sim/hooks/queries/workspace-files.ts

@@ -223,9 +223,20 @@ async function uploadViaApiFallback(
     signal,
   })
 
-  const data = await response.json()
-  if (!data.success) {
-    throw new Error(data.error || 'Upload failed')
+  return parseUploadResponse(response, 'Upload failed')
+}
+
+async function parseUploadResponse(
+  response: Response,
+  fallbackMessage: string
+): Promise<UploadFileResponse> {
+  let data: { success?: boolean; error?: string; file?: WorkspaceFileRecord } | null = null
+  try {
+    data = await response.json()
+  } catch {}
+
+  if (!response.ok || !data?.success) {
+    throw new Error(data?.error || `${fallbackMessage} (${response.status})`)
   }
   return data as UploadFileResponse
 }
@@ -265,11 +276,7 @@ async function uploadWorkspaceFile(
     signal,
   })
 
-  const data = await registerResponse.json()
-  if (!data.success) {
-    throw new Error(data.error || 'Failed to register file')
-  }
-  return data as UploadFileResponse
+  return parseUploadResponse(registerResponse, 'Failed to register file')
 }
 
 export function useUploadWorkspaceFile() {

apps/sim/lib/uploads/contexts/workspace/workspace-file-manager.ts

@@ -25,6 +25,7 @@ import {
   uploadFile,
 } from '@/lib/uploads/core/storage-service'
 import { getFileMetadataByKey, insertFileMetadata } from '@/lib/uploads/server/metadata'
+import { MAX_WORKSPACE_FILE_SIZE } from '@/lib/uploads/shared/types'
 import { getWorkspaceWithOwner } from '@/lib/workspaces/permissions/utils'
 import { isUuid, sanitizeFileName } from '@/executor/constants'
 import type { UserFile } from '@/executor/types'
@@ -301,8 +302,23 @@ export async function registerUploadedWorkspaceFile(params: {
     verifiedSize = head.size ?? size
   }
 
+  const cleanupOrphan = async (reason: string) => {
+    if (!hasCloudStorage()) return
+    try {
+      await deleteFile({ key, context: 'workspace' })
+    } catch (deleteError) {
+      logger.error(`Failed to clean up orphaned object after ${reason}`, deleteError)
+    }
+  }
+
+  if (verifiedSize > MAX_WORKSPACE_FILE_SIZE) {
+    await cleanupOrphan('size-cap rejection')
+    throw new Error(`File size exceeds maximum of ${MAX_WORKSPACE_FILE_SIZE} bytes`)
+  }
+
   const quotaCheck = await checkStorageQuota(userId, verifiedSize)
   if (!quotaCheck.allowed) {
+    await cleanupOrphan('quota rejection')
     throw new Error(quotaCheck.error || 'Storage limit exceeded')
   }
 
@@ -330,13 +346,7 @@ export async function registerUploadedWorkspaceFile(params: {
         'Failed to insert metadata after direct upload; cleaning up storage object',
         insertError
       )
-      if (hasCloudStorage()) {
-        try {
-          await deleteFile({ key, context: 'workspace' })
-        } catch (deleteError) {
-          logger.error('Failed to clean up orphaned storage object', deleteError)
-        }
-      }
+      await cleanupOrphan('metadata insert failure')
       throw insertError
     }
   }