chore(testing): centralize posthog and storage-service mocks

Author: waleedlatif1

apps/sim/app/api/files/delete/route.test.ts

@@ -1,28 +1,25 @@
 /**
  * @vitest-environment node
  */
-import { authMockFns, hybridAuthMockFns } from '@sim/testing'
+import {
+  authMockFns,
+  hybridAuthMockFns,
+  storageServiceMock,
+  storageServiceMockFns,
+} from '@sim/testing'
 import { beforeEach, describe, expect, it, vi } from 'vitest'
 
 const mocks = vi.hoisted(() => {
   const mockVerifyFileAccess = vi.fn()
   const mockVerifyWorkspaceFileAccess = vi.fn()
-  const mockDeleteFile = vi.fn()
-  const mockHasCloudStorage = vi.fn()
   const mockGetStorageProvider = vi.fn()
   const mockIsUsingCloudStorage = vi.fn()
-  const mockUploadFile = vi.fn()
-  const mockDownloadFile = vi.fn()
 
   return {
     mockVerifyFileAccess,
     mockVerifyWorkspaceFileAccess,
-    mockDeleteFile,
-    mockHasCloudStorage,
     mockGetStorageProvider,
     mockIsUsingCloudStorage,
-    mockUploadFile,
-    mockDownloadFile,
   }
 })
 
@@ -68,23 +65,18 @@ vi.mock('@/lib/uploads', () => ({
   getStorageProvider: mocks.mockGetStorageProvider,
   isUsingCloudStorage: mocks.mockIsUsingCloudStorage,
   StorageService: {
-    uploadFile: mocks.mockUploadFile,
-    downloadFile: mocks.mockDownloadFile,
-    deleteFile: mocks.mockDeleteFile,
-    hasCloudStorage: mocks.mockHasCloudStorage,
+    uploadFile: storageServiceMockFns.mockUploadFile,
+    downloadFile: storageServiceMockFns.mockDownloadFile,
+    deleteFile: storageServiceMockFns.mockDeleteFile,
+    hasCloudStorage: storageServiceMockFns.mockHasCloudStorage,
   },
-  uploadFile: mocks.mockUploadFile,
-  downloadFile: mocks.mockDownloadFile,
-  deleteFile: mocks.mockDeleteFile,
-  hasCloudStorage: mocks.mockHasCloudStorage,
+  uploadFile: storageServiceMockFns.mockUploadFile,
+  downloadFile: storageServiceMockFns.mockDownloadFile,
+  deleteFile: storageServiceMockFns.mockDeleteFile,
+  hasCloudStorage: storageServiceMockFns.mockHasCloudStorage,
 }))
 
-vi.mock('@/lib/uploads/core/storage-service', () => ({
-  uploadFile: mocks.mockUploadFile,
-  downloadFile: mocks.mockDownloadFile,
-  deleteFile: mocks.mockDeleteFile,
-  hasCloudStorage: mocks.mockHasCloudStorage,
-}))
+vi.mock('@/lib/uploads/core/storage-service', () => storageServiceMock)
 
 vi.mock('@/lib/uploads/server/metadata', () => ({
   deleteFileMetadata: vi.fn().mockResolvedValue(undefined),
@@ -117,14 +109,14 @@ describe('File Delete API Route', () => {
     })
     mocks.mockVerifyFileAccess.mockResolvedValue(true)
     mocks.mockVerifyWorkspaceFileAccess.mockResolvedValue(true)
-    mocks.mockDeleteFile.mockResolvedValue(undefined)
-    mocks.mockHasCloudStorage.mockReturnValue(true)
+    storageServiceMockFns.mockDeleteFile.mockResolvedValue(undefined)
+    storageServiceMockFns.mockHasCloudStorage.mockReturnValue(true)
     mocks.mockGetStorageProvider.mockReturnValue('s3')
     mocks.mockIsUsingCloudStorage.mockReturnValue(true)
   })
 
   it('should handle local file deletion successfully', async () => {
-    mocks.mockHasCloudStorage.mockReturnValue(false)
+    storageServiceMockFns.mockHasCloudStorage.mockReturnValue(false)
     mocks.mockGetStorageProvider.mockReturnValue('local')
     mocks.mockIsUsingCloudStorage.mockReturnValue(false)
 
@@ -142,7 +134,7 @@ describe('File Delete API Route', () => {
   })
 
   it('should handle file not found gracefully', async () => {
-    mocks.mockHasCloudStorage.mockReturnValue(false)
+    storageServiceMockFns.mockHasCloudStorage.mockReturnValue(false)
     mocks.mockGetStorageProvider.mockReturnValue('local')
     mocks.mockIsUsingCloudStorage.mockReturnValue(false)
 
@@ -170,7 +162,7 @@ describe('File Delete API Route', () => {
     expect(data).toHaveProperty('success', true)
     expect(data).toHaveProperty('message', 'File deleted successfully')
 
-    expect(mocks.mockDeleteFile).toHaveBeenCalledWith({
+    expect(storageServiceMockFns.mockDeleteFile).toHaveBeenCalledWith({
       key: 'workspace/test-workspace-id/1234567890-test-file.txt',
       context: 'workspace',
     })
@@ -190,7 +182,7 @@ describe('File Delete API Route', () => {
     expect(data).toHaveProperty('success', true)
     expect(data).toHaveProperty('message', 'File deleted successfully')
 
-    expect(mocks.mockDeleteFile).toHaveBeenCalledWith({
+    expect(storageServiceMockFns.mockDeleteFile).toHaveBeenCalledWith({
       key: 'workspace/test-workspace-id/1234567890-test-document.pdf',
       context: 'workspace',
     })

apps/sim/app/api/files/parse/route.test.ts

@@ -10,6 +10,8 @@ import {
   inputValidationMock,
   permissionsMock,
   permissionsMockFns,
+  storageServiceMock,
+  storageServiceMockFns,
 } from '@sim/testing'
 import { NextRequest } from 'next/server'
 import { afterEach, beforeEach, describe, expect, it, vi } from 'vitest'
@@ -22,8 +24,6 @@ const {
   mockIsSupportedFileType,
   mockParseFile,
   mockParseBuffer,
-  mockDownloadFile,
-  mockHasCloudStorage,
   mockFsAccess,
   mockFsStat,
   mockFsReadFile,
@@ -47,8 +47,6 @@ const {
       content: 'parsed buffer content',
       metadata: { pageCount: 1 },
     }),
-    mockDownloadFile: vi.fn(),
-    mockHasCloudStorage: vi.fn().mockReturnValue(true),
     mockFsAccess: vi.fn().mockResolvedValue(undefined),
     mockFsStat: vi.fn().mockImplementation(() => ({ isFile: () => true })),
     mockFsReadFile: vi.fn().mockResolvedValue(Buffer.from('test file content')),
@@ -79,10 +77,7 @@ vi.mock('@/lib/file-parsers', () => ({
   parseBuffer: mockParseBuffer,
 }))
 
-vi.mock('@/lib/uploads/core/storage-service', () => ({
-  downloadFile: mockDownloadFile,
-  hasCloudStorage: mockHasCloudStorage,
-}))
+vi.mock('@/lib/uploads/core/storage-service', () => storageServiceMock)
 
 vi.mock('path', () => ({
   default: actualPath,
@@ -176,6 +171,7 @@ describe('File Parse API Route', () => {
     })
 
     permissionsMockFns.mockGetUserEntityPermissions.mockResolvedValue({ canView: true })
+    storageServiceMockFns.mockHasCloudStorage.mockReturnValue(true)
     mockIsSupportedFileType.mockReturnValue(true)
     mockParseFile.mockResolvedValue({
       content: 'parsed content',
@@ -325,8 +321,8 @@ describe('File Parse API Route', () => {
       authenticated: true,
     })
 
-    mockDownloadFile.mockRejectedValue(new Error('Access denied'))
-    mockHasCloudStorage.mockReturnValue(true)
+    storageServiceMockFns.mockDownloadFile.mockRejectedValue(new Error('Access denied'))
+    storageServiceMockFns.mockHasCloudStorage.mockReturnValue(true)
 
     const req = new NextRequest('http://localhost:3000/api/files/parse', {
       method: 'POST',

apps/sim/app/api/files/presigned/route.test.ts

@@ -4,7 +4,7 @@
  * @vitest-environment node
  */
 
-import { authMockFns } from '@sim/testing'
+import { authMockFns, storageServiceMock, storageServiceMockFns } from '@sim/testing'
 import { NextRequest } from 'next/server'
 import { afterEach, beforeEach, describe, expect, it, vi } from 'vitest'
 
@@ -16,9 +16,6 @@ const {
   mockGetStorageConfig,
   mockIsUsingCloudStorage,
   mockGetStorageProvider,
-  mockHasCloudStorage,
-  mockGeneratePresignedUploadUrl,
-  mockGeneratePresignedDownloadUrl,
   mockValidateFileType,
   mockGenerateCopilotUploadUrl,
   mockIsImageFileType,
@@ -32,9 +29,6 @@ const {
   mockGetStorageConfig: vi.fn(),
   mockIsUsingCloudStorage: vi.fn(),
   mockGetStorageProvider: vi.fn(),
-  mockHasCloudStorage: vi.fn(),
-  mockGeneratePresignedUploadUrl: vi.fn(),
-  mockGeneratePresignedDownloadUrl: vi.fn().mockResolvedValue('https://example.com/presigned-url'),
   mockValidateFileType: vi.fn().mockReturnValue(null),
   mockGenerateCopilotUploadUrl: vi.fn().mockResolvedValue({
     url: 'https://example.com/presigned-url',
@@ -63,11 +57,7 @@ vi.mock('@/lib/uploads/config', () => ({
   getStorageProvider: mockGetStorageProvider,
 }))
 
-vi.mock('@/lib/uploads/core/storage-service', () => ({
-  hasCloudStorage: mockHasCloudStorage,
-  generatePresignedUploadUrl: mockGeneratePresignedUploadUrl,
-  generatePresignedDownloadUrl: mockGeneratePresignedDownloadUrl,
-}))
+vi.mock('@/lib/uploads/core/storage-service', () => storageServiceMock)
 
 vi.mock('@/lib/uploads/utils/validation', () => ({
   validateFileType: mockValidateFileType,
@@ -132,8 +122,8 @@ function setupFileApiMocks(
     storageProvider === 'blob' ? 'Azure Blob' : storageProvider === 's3' ? 'S3' : 'Local'
   )
 
-  mockHasCloudStorage.mockReturnValue(cloudEnabled)
-  mockGeneratePresignedUploadUrl.mockImplementation(
+  storageServiceMockFns.mockHasCloudStorage.mockReturnValue(cloudEnabled)
+  storageServiceMockFns.mockGeneratePresignedUploadUrl.mockImplementation(
     async (opts: { fileName: string; context: string }) => {
       const timestamp = Date.now()
       const safeFileName = opts.fileName.replace(/[^a-zA-Z0-9.-]/g, '_')
@@ -144,7 +134,9 @@ function setupFileApiMocks(
       }
     }
   )
-  mockGeneratePresignedDownloadUrl.mockResolvedValue('https://example.com/presigned-url')
+  storageServiceMockFns.mockGeneratePresignedDownloadUrl.mockResolvedValue(
+    'https://example.com/presigned-url'
+  )
 
   mockValidateFileType.mockReturnValue(null)
 
@@ -431,7 +423,7 @@ describe('/api/files/presigned', () => {
         storageProvider: 's3',
       })
 
-      mockGeneratePresignedUploadUrl.mockRejectedValue(
+      storageServiceMockFns.mockGeneratePresignedUploadUrl.mockRejectedValue(
         new Error('Unknown storage provider: unknown')
       )
 
@@ -458,7 +450,9 @@ describe('/api/files/presigned', () => {
         storageProvider: 's3',
       })
 
-      mockGeneratePresignedUploadUrl.mockRejectedValue(new Error('S3 service unavailable'))
+      storageServiceMockFns.mockGeneratePresignedUploadUrl.mockRejectedValue(
+        new Error('S3 service unavailable')
+      )
 
       const request = new NextRequest('http://localhost:3000/api/files/presigned?type=chat', {
         method: 'POST',
@@ -483,7 +477,9 @@ describe('/api/files/presigned', () => {
         storageProvider: 'blob',
       })
 
-      mockGeneratePresignedUploadUrl.mockRejectedValue(new Error('Azure service unavailable'))
+      storageServiceMockFns.mockGeneratePresignedUploadUrl.mockRejectedValue(
+        new Error('Azure service unavailable')
+      )
 
       const request = new NextRequest('http://localhost:3000/api/files/presigned?type=chat', {
         method: 'POST',

apps/sim/app/api/files/serve/[...path]/route.test.ts

@@ -3,15 +3,14 @@
  *
  * @vitest-environment node
  */
-import { hybridAuthMockFns } from '@sim/testing'
+import { hybridAuthMockFns, storageServiceMock, storageServiceMockFns } from '@sim/testing'
 import { NextRequest } from 'next/server'
 import { beforeEach, describe, expect, it, vi } from 'vitest'
 
 const {
   mockVerifyFileAccess,
   mockReadFile,
   mockIsUsingCloudStorage,
-  mockDownloadFile,
   mockDownloadCopilotFile,
   mockInferContextFromKey,
   mockGetContentType,
@@ -30,7 +29,6 @@ const {
     mockVerifyFileAccess: vi.fn(),
     mockReadFile: vi.fn(),
     mockIsUsingCloudStorage: vi.fn(),
-    mockDownloadFile: vi.fn(),
     mockDownloadCopilotFile: vi.fn(),
     mockInferContextFromKey: vi.fn(),
     mockGetContentType: vi.fn(),
@@ -58,10 +56,7 @@ vi.mock('@/lib/uploads', () => ({
   isUsingCloudStorage: mockIsUsingCloudStorage,
 }))
 
-vi.mock('@/lib/uploads/core/storage-service', () => ({
-  downloadFile: mockDownloadFile,
-  hasCloudStorage: vi.fn().mockReturnValue(true),
-}))
+vi.mock('@/lib/uploads/core/storage-service', () => storageServiceMock)
 
 vi.mock('@/lib/uploads/utils/file-utils', () => ({
   inferContextFromKey: mockInferContextFromKey,
@@ -104,6 +99,7 @@ describe('File Serve API Route', () => {
     mockVerifyFileAccess.mockResolvedValue(true)
     mockReadFile.mockResolvedValue(Buffer.from('test content'))
     mockIsUsingCloudStorage.mockReturnValue(false)
+    storageServiceMockFns.mockHasCloudStorage.mockReturnValue(true)
     mockInferContextFromKey.mockReturnValue('workspace')
     mockGetContentType.mockReturnValue('text/plain')
     mockFindLocalFile.mockReturnValue('/test/uploads/test-file.txt')
@@ -161,7 +157,7 @@ describe('File Serve API Route', () => {
 
   it('should serve cloud file by downloading and proxying', async () => {
     mockIsUsingCloudStorage.mockReturnValue(true)
-    mockDownloadFile.mockResolvedValue(Buffer.from('test cloud file content'))
+    storageServiceMockFns.mockDownloadFile.mockResolvedValue(Buffer.from('test cloud file content'))
     mockGetContentType.mockReturnValue('image/png')
 
     const req = new NextRequest(
@@ -174,7 +170,7 @@ describe('File Serve API Route', () => {
     expect(response.status).toBe(200)
     expect(response.headers.get('Content-Type')).toBe('image/png')
 
-    expect(mockDownloadFile).toHaveBeenCalledWith({
+    expect(storageServiceMockFns.mockDownloadFile).toHaveBeenCalledWith({
       key: 'workspace/test-workspace-id/1234567890-image.png',
       context: 'workspace',
     })

apps/sim/app/api/files/upload/route.test.ts

@@ -3,7 +3,14 @@
  *
  * @vitest-environment node
  */
-import { authMockFns, hybridAuthMockFns, permissionsMock, permissionsMockFns } from '@sim/testing'
+import {
+  authMockFns,
+  hybridAuthMockFns,
+  permissionsMock,
+  permissionsMockFns,
+  storageServiceMock,
+  storageServiceMockFns,
+} from '@sim/testing'
 import { NextRequest } from 'next/server'
 import { afterEach, beforeEach, describe, expect, it, vi } from 'vitest'
 
@@ -16,8 +23,6 @@ const mocks = vi.hoisted(() => {
   const mockGetStorageProvider = vi.fn()
   const mockIsUsingCloudStorage = vi.fn()
   const mockUploadFile = vi.fn()
-  const mockHasCloudStorage = vi.fn()
-  const mockStorageUploadFile = vi.fn()
 
   return {
     mockVerifyFileAccess,
@@ -28,8 +33,6 @@ const mocks = vi.hoisted(() => {
     mockGetStorageProvider,
     mockIsUsingCloudStorage,
     mockUploadFile,
-    mockHasCloudStorage,
-    mockStorageUploadFile,
   }
 })
 
@@ -85,10 +88,7 @@ vi.mock('@/lib/uploads', () => ({
   uploadFile: mocks.mockUploadFile,
 }))
 
-vi.mock('@/lib/uploads/core/storage-service', () => ({
-  uploadFile: mocks.mockStorageUploadFile,
-  hasCloudStorage: mocks.mockHasCloudStorage,
-}))
+vi.mock('@/lib/uploads/core/storage-service', () => storageServiceMock)
 
 vi.mock('@/lib/uploads/setup.server', () => ({
   UPLOAD_DIR_SERVER: '/tmp/test-uploads',
@@ -153,8 +153,8 @@ function setupFileApiMocks(
     type: 'text/plain',
   })
 
-  mocks.mockHasCloudStorage.mockReturnValue(cloudEnabled)
-  mocks.mockStorageUploadFile.mockResolvedValue({
+  storageServiceMockFns.mockHasCloudStorage.mockReturnValue(cloudEnabled)
+  storageServiceMockFns.mockUploadFile.mockResolvedValue({
     key: 'test-key',
     path: '/test/path',
   })
@@ -325,8 +325,8 @@ describe('File Upload Security Tests', () => {
       user: { id: 'test-user-id' },
     })
 
-    mocks.mockHasCloudStorage.mockReturnValue(false)
-    mocks.mockStorageUploadFile.mockResolvedValue({
+    storageServiceMockFns.mockHasCloudStorage.mockReturnValue(false)
+    storageServiceMockFns.mockUploadFile.mockResolvedValue({
       key: 'test-key',
       path: '/test/path',
     })