Skip to content

remove unused fields#126

Merged
noctarius merged 4 commits into
mainfrom
remove-un-used-fields
May 21, 2026
Merged

remove unused fields#126
noctarius merged 4 commits into
mainfrom
remove-un-used-fields

Conversation

@boddumanohar
Copy link
Copy Markdown
Member

@boddumanohar boddumanohar commented May 13, 2026

  • StorageCluster.spec.clusterName field is removed as it duplicates StorageCluster.metadata.name
  • Pool.spec.name field is removed as it duplicates Pool.metadata.name
  • clusterImage field is not required as it will be inherited from ControlPlane CRD

@github-actions
Copy link
Copy Markdown
Contributor

🤖: Deployment available as https://docstest.simplyblock.io/remove-un-used-fields

1 similar comment
@github-actions
Copy link
Copy Markdown
Contributor

🤖: Deployment available as https://docstest.simplyblock.io/remove-un-used-fields

name: simplyblock-cluster
namespace: simplyblock
spec:
clusterName: production
Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does that mean we changes from an array to a pure object?

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No, this is change is made only to the StorageCluster object. The clusterName field duplicates the metadata.name. So the field clusterName is redundant.

The change from Array to pure object is needed in the case of StorageNode.workerNodes where single StorageNode object is used to present multiple storage nodes.

@noctarius
Copy link
Copy Markdown
Collaborator

And we'd also need to add the CP CRD to the operator reference, don't we?

@github-actions
Copy link
Copy Markdown
Contributor

🤖: Deployment available as https://docstest.simplyblock.io/remove-un-used-fields

@boddumanohar
Copy link
Copy Markdown
Member Author

The operator CRD needs to be updated for other CRDs too. We had a quite a few changes. I working on a way to autogenerate the operator.md file.

@github-actions
Copy link
Copy Markdown
Contributor

🤖: Deployment available as https://docstest.simplyblock.io/remove-un-used-fields

noctarius
noctarius previously approved these changes May 21, 2026
@noctarius
Copy link
Copy Markdown
Collaborator

The operator CRD needs to be updated for other CRDs too. We had a quite a few changes. I working on a way to autogenerate the operator.md file.

I'll merge this here anyways. We have the other PR already, and I'll integrate it afterwards.

@github-actions
Copy link
Copy Markdown
Contributor

🤖: Deployment available as https://docstest.simplyblock.io/remove-un-used-fields

@noctarius noctarius merged commit 4f3b3ea into main May 21, 2026
3 checks passed
@noctarius noctarius deleted the remove-un-used-fields branch May 21, 2026 13:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants