Add Phoque and Phoque2a current sense#90
Open
Moddingear wants to merge 1 commit into
Open
Conversation
|
Memory usage change @ 1d7c972
Click for full report table
Click for full report CSV |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Yes, the boards aren't available yet, and Phoque2a is an alpha version.
Yet, I believe that this implementation of current sense is good, and could be applied to BG431-ESC1 with only a few modifications (it could even reuse the common Phoque_CurrentSense class).
Most notable, is that the ADC channels are resolved at runtime, so this leaves less room for error, the calibration doesn't wait 1ms every round, making it run ~20 times faster (if at 20kHz), and driver align is removed so around 3.8K of code is freed from the flash.
Furthermore, the ADC can be configured to read from more channels by making a class inherit from Phoque2a_CurrentSense and adding some more ADC channels to the planned channels.
Using the same framework, Phoque1 and Phoque2 will be supported. (Technically, Phoque2 doesn't have any analog pin change, so it will probably be the same class)