Guard background messaging and detect startup paths#290
Open
geauxtigers wants to merge 1 commit intosimov:mainfrom
Open
Guard background messaging and detect startup paths#290geauxtigers wants to merge 1 commit intosimov:mainfrom
geauxtigers wants to merge 1 commit intosimov:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR adds two defensive guards in the background scripts:
Changes
background/messages.js,notifyContent()now:chrome.runtime.lastErrorwhen a tab has no receiving content scriptbackground/detect.js,detect()now returns early when the URL orstate.originsis not yet availableWhy
While testing locally, the extension could emit background errors in normal browsing cases:
state.originsbefore initialization completedThese guards make those paths no-op safely instead of surfacing runtime noise.
Scope
This PR intentionally does not include the copy-button feature work.