SF-2722 Send blank ops created when the user comes online to ShareDB#3935
Open
pmachapman wants to merge 1 commit into
Open
SF-2722 Send blank ops created when the user comes online to ShareDB#3935pmachapman wants to merge 1 commit into
pmachapman wants to merge 1 commit into
Conversation
pmachapman
added
the
will require testing
pmachapman
temporarily deployed
to
screenshot_diff
GitHub Actions
Inactive
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #3935 +/- ##
==========================================
+ Coverage 80.66% 80.67% +0.01%
==========================================
Files 634 634
Lines 41090 41092 +2
Branches 6681 6682 +1
==========================================
+ Hits 33144 33150 +6
+ Misses 6893 6890 -3
+ Partials 1053 1052 -1 ☔ View full report in Codecov by Harness. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR where verse numbers disappear when coming online then editing a text by ensuring that an blank ops created by
fixSegments()make their way to ShareDB.This change is