SF-3826 Do not upload a base project to Serval if it is incomplete

[pmachapman]

This PR fixes a bug on QA where a base project missing the writing system and the directory on disk causes the build to fail.

Due to the odd nature of the bug, it should be tested on QA, so I have marked as testing not required as it should be merged then tested on QA.

---

This change is 

[codecov]

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 80.86%. Comparing base (c0b63e6) to head (3cc24bd).
✅ All tests successful. No failed tests found.

Additional details and impacted files

@@           Coverage Diff           @@
##           master    #3934   +/-   ##
=======================================
  Coverage   80.86%   80.86%           
=======================================
  Files         634      634           
  Lines       40997    41004    +7     
  Branches     6674     6675    +1     
=======================================
+ Hits        33151    33158    +7     
  Misses       6795     6795           
  Partials     1051     1051           

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

[Nateowami]

@Nateowami made 1 comment.
Reviewable status: 0 of 2 files reviewed, 1 unresolved discussion (waiting on pmachapman).

---

src/SIL.XForge.Scripture/Services/MachineProjectService.cs line 1730 at r1 (raw file):

                    cancellationToken
                );
            if (baseProject is not null)

The old source has a null check. The new logic assumes baseProject can never be null. Is there a good reason to not be concerned it might be null ?

[pmachapman]

@pmachapman made 1 comment and resolved 1 discussion.
Reviewable status: 0 of 2 files reviewed, all discussions resolved (waiting on Nateowami).

---

src/SIL.XForge.Scripture/Services/MachineProjectService.cs line 1730 at r1 (raw file):

Previously, Nateowami wrote…

The old source has a null check. The new logic assumes baseProject can never be null. Is there a good reason to not be concerned it might be null ?

Done. I don't know where that went - thank you!

[RaymondLuong3]

@RaymondLuong3 reviewed 2 files and all commit messages.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on pmachapman).