Skip to content

SF-2956 Fix import question dialog offline error message color#3918

Draft
Nateowami wants to merge 1 commit into
masterfrom
fix/SF-2956-question-import-dialog-offline-messages
Draft

SF-2956 Fix import question dialog offline error message color#3918
Nateowami wants to merge 1 commit into
masterfrom
fix/SF-2956-question-import-dialog-offline-messages

Conversation

@Nateowami

@Nateowami Nateowami commented Jun 1, 2026

Copy link
Copy Markdown
Collaborator

Fixes the color of the offline error messages (previously they were black).

localhost_5000_projects_6a037a701b73edc272a0c520_checking

This change is Reviewable

@Nateowami Nateowami added the will require testing PR should not be merged until testers confirm testing is complete label Jun 1, 2026
@marksvc marksvc self-assigned this Jun 1, 2026
@marksvc

marksvc commented Jun 1, 2026

Copy link
Copy Markdown
Collaborator

This is reviewable in Devin Review.

@Nateowami Nateowami temporarily deployed to screenshot_diff June 1, 2026 21:12 — with GitHub Actions Inactive
@codecov

codecov Bot commented Jun 1, 2026

Copy link
Copy Markdown

❌ 2 Tests Failed:

Tests completed Failed Passed Skipped
4871 2 4869 3
View the top 2 failed test(s) by shortest run time
.ImportQuestionsDialogComponent Import from Paratext::ImportQuestionsDialogComponent Import from Paratext disables import button when user is offline
Stack Traces | 0.021s run time
Error: Expected undefined to equal 'Importing from Paratext is not available offline.'.
    at <Jasmine>
    at UserContext.<anonymous> (.../checking/import-questions-dialog/import-questions-dialog.component.spec.ts:560:36)
    at UserContext.fakeAsyncFn (node_modules/zone.js/fesm2015/zone-testing.js:1715:26)
    at _ZoneDelegate.invoke (node_modules/zone.js/fesm2015/zone.js:398:28)
.ImportQuestionsDialogComponent::ImportQuestionsDialogComponent does not try to load transcelerator questions when the user is online
Stack Traces | 0.036s run time
Error: Expected undefined to equal 'Importing from Transcelerator is not available offline.'.
    at <Jasmine>
    at UserContext.<anonymous> (.../checking/import-questions-dialog/import-questions-dialog.component.spec.ts:518:34)
    at UserContext.fakeAsyncFn (node_modules/zone.js/fesm2015/zone-testing.js:1715:26)
    at _ZoneDelegate.invoke (node_modules/zone.js/fesm2015/zone.js:398:28)

To view more test analytics, go to the Test Analytics Dashboard
📋 Got 3 mins? Take this short survey to help us improve Test Analytics.

@marksvc marksvc left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you. BTW, I notice that there are a number of other mat-error element usages in this class. If the problem is that mat-error was being used outside of mat-form-field, then there are a few other places where the text will similarly not be styled as intended.

@marksvc reviewed 1 file and all commit messages, and made 1 comment.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on Nateowami).

@Nateowami Nateowami marked this pull request as draft June 2, 2026 13:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

will require testing PR should not be merged until testers confirm testing is complete

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants