SF-2956 Fix import question dialog offline error message color#3918
Draft
Nateowami wants to merge 1 commit into
Draft
SF-2956 Fix import question dialog offline error message color#3918Nateowami wants to merge 1 commit into
Nateowami wants to merge 1 commit into
Conversation
Collaborator
|
This is reviewable in Devin Review. |
❌ 2 Tests Failed:
View the top 2 failed test(s) by shortest run time
To view more test analytics, go to the Test Analytics Dashboard |
marksvc
approved these changes
Jun 1, 2026
marksvc
left a comment
Collaborator
There was a problem hiding this comment.
Thank you. BTW, I notice that there are a number of other mat-error element usages in this class. If the problem is that mat-error was being used outside of mat-form-field, then there are a few other places where the text will similarly not be styled as intended.
@marksvc reviewed 1 file and all commit messages, and made 1 comment.
Reviewable status:complete! all files reviewed, all discussions resolved (waiting on Nateowami).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes the color of the offline error messages (previously they were black).
This change is