Skip to content

Draft jobs table: Use earliest Retrieve status event for finish event#3698

Merged
RaymondLuong3 merged 1 commit intomasterfrom
task/earliest
Feb 19, 2026
Merged

Draft jobs table: Use earliest Retrieve status event for finish event#3698
RaymondLuong3 merged 1 commit intomasterfrom
task/earliest

Conversation

@marksvc
Copy link
Copy Markdown
Collaborator

@marksvc marksvc commented Feb 18, 2026

It already would have been because of sorting, but add a test about it
and sort right there when deciding between Retrieve events, to ensure
using earliest.


This change is Reviewable


Open with Devin

@marksvc marksvc added testing not required e2e Run e2e tests for this pull request labels Feb 18, 2026
@codecov
Copy link
Copy Markdown

codecov bot commented Feb 19, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 81.83%. Comparing base (5e6d0c0) to head (121ceaf).
⚠️ Report is 95 commits behind head on master.
✅ All tests successful. No failed tests found.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #3698   +/-   ##
=======================================
  Coverage   81.83%   81.83%           
=======================================
  Files         619      619           
  Lines       38622    38623    +1     
  Branches     6317     6317           
=======================================
+ Hits        31605    31606    +1     
  Misses       6043     6043           
  Partials      974      974           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@marksvc marksvc marked this pull request as ready for review February 19, 2026 15:27
Copy link
Copy Markdown
Collaborator

@RaymondLuong3 RaymondLuong3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@RaymondLuong3 reviewed 2 files and all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on marksvc).

@RaymondLuong3 RaymondLuong3 self-assigned this Feb 19, 2026
It already would have been because of sorting, but add a test about it
and sort right there when deciding between Retrieve events, to ensure
using earliest.
@RaymondLuong3 RaymondLuong3 removed the e2e Run e2e tests for this pull request label Feb 19, 2026
@RaymondLuong3 RaymondLuong3 merged commit 2d11aef into master Feb 19, 2026
20 of 21 checks passed
@RaymondLuong3 RaymondLuong3 deleted the task/earliest branch February 19, 2026 20:48
Copy link
Copy Markdown

@devin-ai-integration devin-ai-integration bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ Devin Review: No Issues Found

Devin Review analyzed this PR and found no potential bugs to report.

View in Devin Review to see 2 additional findings.

Open in Devin Review

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants