Skip to content

Add typechecking to linting#8

Merged
imnasnainaec merged 1 commit intomainfrom
typecheck
Feb 19, 2026
Merged

Add typechecking to linting#8
imnasnainaec merged 1 commit intomainfrom
typecheck

Conversation

@imnasnainaec
Copy link
Contributor

@imnasnainaec imnasnainaec commented Feb 6, 2026

Fixes #7


This change is Reviewable

Summary by CodeRabbit

  • Chores
    • Linting now runs an additional type-check step as part of the standard lint command.
    • Compiler settings updated to skip type-checking of third-party declaration files, altering how library typings are validated during builds.

@imnasnainaec imnasnainaec self-assigned this Feb 6, 2026
@imnasnainaec imnasnainaec added the 🟨Medium Medium-priority PR label Feb 6, 2026
@coderabbitai
Copy link

coderabbitai bot commented Feb 6, 2026

📝 Walkthrough

Walkthrough

Added a TypeScript type-check step to the lint workflow by adding a lint:typecheck script and invoking it from the main lint script; also set skipLibCheck: true in tsconfig.json.

Changes

Cohort / File(s) Summary
Lint scripts
package.json
Added lint:typecheck (runs tsc --noEmit) and updated lint script to run lint:scripts, lint:styles, and lint:typecheck.
TypeScript config
tsconfig.json
Added skipLibCheck: true to compilerOptions to skip type-checking of declaration files.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Poem

🐰 I hopped through scripts with a careful peep,
Added a typecheck to catch what creeps,
Skipped the lib noise, focused the sight,
Now lint and tsc keep our code polite. 🥕

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Title check ✅ Passed The title 'Add typechecking to linting' accurately describes the main change: adding a lint:typecheck script and integrating it into the lint process.
Linked Issues check ✅ Passed The PR addresses issue #7 by adding typechecking to the lint step, causing npm run lint to fail when TypeScript errors are present in .tsx files.
Out of Scope Changes check ✅ Passed All changes are directly related to issue #7: adding lint:typecheck script, integrating it into lint, and configuring TypeScript with skipLibCheck.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
  • 📝 Generate docstrings
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch typecheck

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@imnasnainaec imnasnainaec marked this pull request as ready for review February 19, 2026 13:31
@imnasnainaec imnasnainaec merged commit 1e90d37 into main Feb 19, 2026
7 of 8 checks passed
@imnasnainaec imnasnainaec deleted the typecheck branch February 19, 2026 13:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

🟨Medium Medium-priority PR

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Lint not failing when our .tsx files have ts issues.

2 participants

Comments