Skip to content

[NoteButton] Use multiline text field for wordwrap#4157

Merged
imnasnainaec merged 2 commits intomasterfrom
note-text-multiline
Feb 23, 2026
Merged

[NoteButton] Use multiline text field for wordwrap#4157
imnasnainaec merged 2 commits intomasterfrom
note-text-multiline

Conversation

@imnasnainaec
Copy link
Copy Markdown
Collaborator

@imnasnainaec imnasnainaec commented Feb 16, 2026

Resolves #4156

Also: Removes unnecessary color="primary" prop on the dialog buttons and changes the confirm button to variant="contained".


This change is Reviewable

Summary by CodeRabbit

  • New Features

    • Text input dialogs now support multiline text entry.
  • Improvements

    • Enhanced keyboard behavior: pressing Enter now confirms the dialog instead of inserting a new line.
    • Updated button styling for better visual consistency.

@coderabbitai
Copy link
Copy Markdown

coderabbitai Bot commented Feb 16, 2026

Warning

Rate limit exceeded

@imnasnainaec has exceeded the limit for the number of commits that can be reviewed per hour. Please wait 5 minutes and 4 seconds before requesting another review.

⌛ How to resolve this issue?

After the wait time has elapsed, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

We recommend that you space out your commits to avoid hitting the rate limit.

🚦 How do rate limits work?

CodeRabbit enforces hourly rate limits for each developer per organization.

Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout.

Please see our FAQ for further information.

📝 Walkthrough

Walkthrough

The changes introduce multiline text input capability to the note editing dialog. EditTextDialog now accepts a multiline prop that enables word-wrapped input, while modifying Enter key behavior to trigger confirmation rather than insert a newline. NoteButton applies this new prop when instantiating the dialog.

Changes

Cohort / File(s) Summary
Multiline Note Input
src/components/Dialogs/EditTextDialog.tsx, src/components/Buttons/NoteButton.tsx
Added optional multiline prop to EditTextDialogProps and applied it to the underlying TextField. Modified Enter key handling from onKeyPress to onKeyDown with preventDefault to avoid newline insertion and trigger onConfirm instead. Updated button styling by removing explicit color prop from Cancel button and setting Confirm button variant to contained.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~12 minutes

Poem

🐰 A note field grows, no more confined,
With multiline wisdom, word-wrapped and kind,
A keystroke confirms what we've typed with care,
Resizable comfort, thoughts flowing fair!

🚥 Pre-merge checks | ✅ 4 | ❌ 2

❌ Failed checks (1 warning, 1 inconclusive)

Check name Status Explanation Resolution
Docstring Coverage ⚠️ Warning Docstring coverage is 66.67% which is insufficient. The required threshold is 80.00%. Write docstrings for the functions missing them to satisfy the coverage threshold.
Out of Scope Changes check ❓ Inconclusive The PR mentions removing color prop and changing button variant, which are changes beyond the core multiline functionality stated in the title. Clarify whether button styling changes (color removal, variant adjustment) are necessary or should be in a separate PR for focused scope.
✅ Passed checks (4 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly summarizes the main change: enabling multiline text field functionality in NoteButton for word wrap support.
Linked Issues check ✅ Passed The PR successfully implements the multiline text field requirement from issue #4156, enabling word wrap and better note input experience.
Merge Conflict Detection ✅ Passed ✅ No merge conflicts detected when merging into master
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch note-text-multiline

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

coderabbitai[bot]

This comment was marked as outdated.

@codecov
Copy link
Copy Markdown

codecov Bot commented Feb 16, 2026

Codecov Report

❌ Patch coverage is 0% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 65.97%. Comparing base (21b27bf) to head (35296df).
⚠️ Report is 54 commits behind head on master.

Files with missing lines Patch % Lines
src/components/Dialogs/EditTextDialog.tsx 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #4157      +/-   ##
==========================================
- Coverage   74.76%   65.97%   -8.80%     
==========================================
  Files         302      246      -56     
  Lines       11068     6245    -4823     
  Branches     1389      791     -598     
==========================================
- Hits         8275     4120    -4155     
+ Misses       2390     1867     -523     
+ Partials      403      258     -145     
Flag Coverage Δ
backend ?
frontend 65.97% <0.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@imnasnainaec imnasnainaec marked this pull request as draft February 17, 2026 19:31
@imnasnainaec imnasnainaec marked this pull request as ready for review February 20, 2026 19:42
Copy link
Copy Markdown
Contributor

@jasonleenaylor jasonleenaylor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jasonleenaylor reviewed 2 files and all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on imnasnainaec).

@imnasnainaec imnasnainaec merged commit 5ebd071 into master Feb 23, 2026
17 checks passed
@imnasnainaec imnasnainaec deleted the note-text-multiline branch February 23, 2026 19:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[DataEntry] Bigger note field

2 participants