Fix LT-22428: Add More than one line and Exactly one line filters#717
Open
jtmaxwell3 wants to merge 2 commits intomainfrom
Open
Fix LT-22428: Add More than one line and Exactly one line filters#717jtmaxwell3 wants to merge 2 commits intomainfrom
jtmaxwell3 wants to merge 2 commits intomainfrom
Conversation
Contributor
jasonleenaylor
left a comment
jasonleenaylor
left a comment
There was a problem hiding this comment.
Is this filter limited to columns which could have multiple lines?
@jasonleenaylor made 1 comment.
Reviewable status: 0 of 6 files reviewed, all discussions resolved.
Contributor
|
I want to run this idea by a couple of people before we merge it. I don't generally like the idea of adding filter options to columns where they do not apply. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixes https://jira.sil.org/browse/LT-22428. We changed allomorph columns and allomorph property columns to include lexeme forms so that the properties would line up with the allomorphs. But this means that users can no longer see just the entries with non-lexeme allomorphs by filtering on Non-blanks. We added filters for More than one line and Exactly one line to handle this use case.
This change is