Skip to content

Fix LT-21893: Crash in Change Spelling#715

Merged
jtmaxwell3 merged 1 commit intomainfrom
LT-21893
Feb 27, 2026
Merged

Fix LT-21893: Crash in Change Spelling#715
jtmaxwell3 merged 1 commit intomainfrom
LT-21893

Conversation

@jtmaxwell3
Copy link
Collaborator

@jtmaxwell3 jtmaxwell3 commented Feb 26, 2026

This fixes https://jira.sil.org/browse/LT-21893.


This change is Reviewable

@github-actions
Copy link

github-actions bot commented Feb 26, 2026

NUnit Tests

    1 files  ±0      1 suites  ±0   6m 10s ⏱️ +11s
4 407 tests ±0  4 320 ✅ ±0  87 💤 ±0  0 ❌ ±0 
4 416 runs  ±0  4 329 ✅ ±0  87 💤 ±0  0 ❌ ±0 

Results for commit 11acb64. ± Comparison against base commit a9a36f5.

♻️ This comment has been updated with latest results.

Copy link
Contributor

@jasonleenaylor jasonleenaylor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It isn't clear to me how this actually resolves a crash.
If you could update the commit comment (amend and force push) to have a second line explaining it I would be happy.

@jasonleenaylor made 1 comment.
Reviewable status: 0 of 1 files reviewed, all discussions resolved.

Copy link
Contributor

@jasonleenaylor jasonleenaylor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

@jasonleenaylor reviewed 1 file and all commit messages, and made 1 comment.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on jtmaxwell3).

@jtmaxwell3 jtmaxwell3 merged commit a14b234 into main Feb 27, 2026
8 of 9 checks passed
@jtmaxwell3 jtmaxwell3 deleted the LT-21893 branch February 27, 2026 22:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants