Skip to content

fix logging issues #681

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
JWinermaSplunk wants to merge 9 commits into
base: main
Choose a base branch
from
Open

fix logging issues #681

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
a85d216
initial commit
JWinermaSplunk Dec 11, 2025
b573d3b
add back traceback
JWinermaSplunk Dec 11, 2025
7f6fb53
try API LogRecord
JWinermaSplunk Dec 16, 2025
33956cd
fix linting
JWinermaSplunk Dec 16, 2025
f970467
Revert "fix linting"
JWinermaSplunk Dec 16, 2025
fdd3f70
lint profile.py
JWinermaSplunk Dec 16, 2025
bf4eeb8
fix linting
JWinermaSplunk Dec 17, 2025
17560da
updates
JWinermaSplunk Dec 17, 2025
f687ddc
re-add Context to LogRecord
JWinermaSplunk Dec 18, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 8 additions & 8 deletions pyproject.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,14 +23,14 @@ classifiers = [
"Programming Language :: Python :: Implementation :: PyPy",
]
dependencies = [
"opentelemetry-api==1.38.0",
"opentelemetry-sdk==1.38.0",
"opentelemetry-propagator-b3==1.38.0",
"opentelemetry-exporter-otlp-proto-grpc==1.38.0",
"opentelemetry-exporter-otlp-proto-http==1.38.0",
"opentelemetry-instrumentation==0.59b0",
"opentelemetry-instrumentation-system-metrics==0.59b0",
"opentelemetry-semantic-conventions==0.59b0",
"opentelemetry-api==1.39.1",
"opentelemetry-sdk==1.39.1",
"opentelemetry-propagator-b3==1.39.1",
"opentelemetry-exporter-otlp-proto-grpc==1.39.1",
"opentelemetry-exporter-otlp-proto-http==1.39.1",
"opentelemetry-instrumentation==0.60b1",
"opentelemetry-instrumentation-system-metrics==0.60b1",
"opentelemetry-semantic-conventions==0.60b1",
"protobuf>=6.31.1", # not our direct dep, prevents installing vulnerable proto versions (CVE‑2025‑4565)
]

Expand Down
13 changes: 7 additions & 6 deletions src/splunk_otel/profile.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,10 +10,9 @@

import opentelemetry.context
import wrapt
from opentelemetry._logs import Logger, SeverityNumber, get_logger
from opentelemetry._logs import Logger, SeverityNumber, get_logger, LogRecord
from opentelemetry.context import Context
from opentelemetry.instrumentation.version import __version__ as version
from opentelemetry.sdk._logs import LogRecord
from opentelemetry.sdk.environment_variables import OTEL_SERVICE_NAME
from opentelemetry.sdk.resources import Resource
from opentelemetry.trace import TraceFlags
Expand Down Expand Up @@ -172,20 +171,22 @@ def tick(self):
def mk_log_record(self, stacktraces):
lengths = (len(trace["frames"]) for trace in stacktraces)
total_frame_count = sum(lengths)

time_seconds = self.time()

pb_profile = _stacktraces_to_cpu_profile(stacktraces, self.thread_states, self.interval_millis, time_seconds)
pb_profile_str = _pb_profile_to_str(pb_profile)

return LogRecord(
timestamp=int(time_seconds * 1e9),
context = Context(
trace_id=0,
span_id=0,
trace_flags=TraceFlags(0x01),
)

return LogRecord(
timestamp=int(time_seconds * 1e9),
context=context,
severity_number=SeverityNumber.UNSPECIFIED,
body=pb_profile_str,
resource=self.resource,
attributes={
"profiling.data.format": "pprof-gzip-base64",
"profiling.data.type": "cpu",
Expand Down