This repository was archived by the owner on Feb 12, 2022. It is now read-only.
upstream unencrypted headers #5
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Author
|
Upstream PR at yapstudios#466 |
|
It'd be nice to get in 764e949 one way or another since we use it in our tests. Note that we may need to update our tests a little anyway. |
Author
I exposed them in the category extension local to the test. signalapp/Signal-iOS@ae488d3#diff-23ab48e4becf5545cca1bc6bd2066d1bL16 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If this looks good to you @charlesmchen, I'll open upstream.
I took https://github.com/signalapp/YapDatabase/tree/release/unencryptedHeaders and:
I'll investigate a bit and see if we can justify upstreaming it in a separate PR, or if we should just keep it in an extension in our own project.