ENG-9909 add support for path-based multi-tenancy#93
Open
ENG-9909 add support for path-based multi-tenancy#93
Conversation
da4370c to
7ab1b51
Compare
7ab1b51 to
26732b9
Compare
mklein0
reviewed
Apr 3, 2026
mklein0
left a comment
There was a problem hiding this comment.
Do we want pycoverage reports event if we do not do pycov? The MA report supports both reporting so that can be referenced.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add new support for path-based multi-tenancy, with options in client initialization.
base_pathparameter to explicitly set the base path for the environmentbase_pathparameter will take precedenceManual testing can be done against
https://sm-nested-path.test.sightmachine.io/nested/one/two/:Also fixed some tests that were already failing in
master. Most of these are due to the fact that it queries for data in thedemoenvironment, and the data available has changed at some point. The final failing test,test_get_line_data, is an actual bug in MA, fixed with https://github.com/sightmachine/ma/pull/8631 .