Double ffmpeg process was being created when receiving multiple onDat…#8
Open
LeandroDG wants to merge 1 commit intosidneys:masterfrom
Open
Double ffmpeg process was being created when receiving multiple onDat…#8LeandroDG wants to merge 1 commit intosidneys:masterfrom
LeandroDG wants to merge 1 commit intosidneys:masterfrom
Conversation
Author
|
Is it possible to get this reviewed and merged? Thanks! |
|
This issue still persists. The CLI runs ffmpeg twice. It also shows negative ETA times, and was jumping from -7h to +8h on every update, so the times were wildly inaccurate. CC @sidneys What's the status on this repository? Should it be archived? |
This was referenced Aug 16, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Running in Windows I got 2 main task processes started as multiple onData calls were executed. This change makes sure that the main task only gets started once.