Conversation
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 4974a2a83a
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| let hasUpstream = snapshot.gitTracking?.hasUpstream ?? false | ||
| let aheadCount = snapshot.gitTracking?.ahead ?? 0 | ||
| let needsPush = !hasUpstream || aheadCount > 0 | ||
|
|
There was a problem hiding this comment.
Handle unknown tracking state without forcing push-first
When gitTracking is missing, this code treats the branch as hasUpstream == false, which makes needsPush always true and disables .openPR/.updatePR as primary outcomes. In repos that are valid GitHub repos but not present in WorktrunkStore (so resolve passes gitTracking: nil), classify will keep choosing push as the smart action; the main toolbar action then sends a push-only prompt that can terminate on “nothing to push” instead of opening/updating the PR.
Useful? React with 👍 / 👎.
Adds a repo-aware split button and command palette actions that type compact repo workflow prompts into the current terminal session.
This includes dynamic next-action resolution, combo shortcuts for the obvious multi-step path, disabled states for unavailable actions, and targeted tests for the prompt classifier and prompt text.
Verified with
git build test -Dtest-filter=TerminalRepoPrompt
zig build