Skip to content

Fix: Use linear curve type for splines with all-linear knots #38

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
CA-Tatami wants to merge 1 commit into
base: Houdini21.0
Choose a base branch
from
Open

Fix: Use linear curve type for splines with all-linear knots #38

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
25 changes: 23 additions & 2 deletions Plugins/HoudiniEngineUnity/Scripts/Utility/HEU_InputInterfaceSpline.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -233,6 +233,7 @@ public class HEU_InputDataSpline
public int _count;
public float _length;
public BezierKnot[] _knots;
public bool _allKnotsLinear;
}

/// <summary>
Expand Down Expand Up @@ -265,6 +266,18 @@ public HEU_InputDataSplineContainer GenerateSplineDataFromGameObject(GameObject
splineData._length = spline.GetLength();
splineData._knots = spline.Knots.ToArray<BezierKnot>();

// Check if all knots use linear tangent mode
bool allLinear = spline.Count > 0;
for (int i = 0; i < spline.Count; i++)
{
if (spline.GetTangentMode(i) != TangentMode.Linear)
{
allLinear = false;
break;
}
}
splineData._allKnotsLinear = allLinear;

splineContainerData._inputSplines.Add(splineData);
}
splineContainerData._transform = inputObject.transform;
Expand All @@ -283,8 +296,16 @@ public bool UploadData(HEU_SessionBase session, HAPI_NodeId inputNodeID, HEU_Inp
{
// Set the input curve info of the newly created input curve
HAPI_InputCurveInfo inputCurveInfo = new HAPI_InputCurveInfo();
inputCurveInfo.curveType = HAPI_CurveType.HAPI_CURVETYPE_BEZIER;
inputCurveInfo.order = 4;
if (inputSpline._allKnotsLinear)
{
inputCurveInfo.curveType = HAPI_CurveType.HAPI_CURVETYPE_LINEAR;
inputCurveInfo.order = 2;
}
else
{
inputCurveInfo.curveType = HAPI_CurveType.HAPI_CURVETYPE_BEZIER;
inputCurveInfo.order = 4;
}
inputCurveInfo.closed = inputSpline._closed;
inputCurveInfo.reverse = false;
inputCurveInfo.inputMethod = HAPI_InputCurveMethod.HAPI_CURVEMETHOD_BREAKPOINTS;
Expand Down