Add support for specifying a custom Logical ID for the AWS::AppSync::GraphQLApi resource#618
Add support for specifying a custom Logical ID for the AWS::AppSync::GraphQLApi resource#618manwaring wants to merge 3 commits into
Conversation
|
|
||
| getAuthenticationEmbeddedLamdbaName() { | ||
| return `${this.apiName}Authorizer`; | ||
| return `${this.config.name}Authorizer`; |
There was a problem hiding this comment.
Is this necessary?
Unless I am missing something, we probably could get away with having a
apiLogicalId that overrides getLogicalId.
The rest of the logical ids should be safe. i.e. They might be re-created but they are not stateful.
That would simplify everything.
| pipelineFunctions: Record<string, PipelineFunctionConfig>; | ||
| substitutions?: Substitutions; | ||
| xrayEnabled?: boolean; | ||
| logicalIdPrefix?: string; |
There was a problem hiding this comment.
As per my other comment, could this be named apiLogicalId?
bboure
left a comment
There was a problem hiding this comment.
Thank you @manwaring
Could we also add documentation of when and how to use it?
|
Closing this in its current form — as noted in review, it makes far more logical IDs The useful, minimal version of this is a single optional Thanks for the contribution and the prod on the use case! |
Exploring a possible solution to #617 by supporting a parameter to prefix the
AWS::AppSync::GraphQLApiLogical ID (instead of only supportingGraphQlApi)