test(nest-logger): add regression tests for NestLogger argument forwarding#81
Closed
Copilot wants to merge 2 commits into#79-nest-loggerfrom
Closed
test(nest-logger): add regression tests for NestLogger argument forwarding#81Copilot wants to merge 2 commits into#79-nest-loggerfrom
Copilot wants to merge 2 commits into#79-nest-loggerfrom
Conversation
Co-authored-by: dario-fazio <207528194+dario-fazio@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] [WIP] Address feedback on unhandled errors logging in Nest logger
test(nest-logger): add regression tests for NestLogger argument forwarding
Mar 19, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
NestLoggerpreviously passed optional params as a nested array to the underlying@shiftcode/logger(e.g.error('msg', 'trace', 'ctx')→args: [['msg', 'trace', 'ctx']]). The fix was applied in #80, but no tests guarded against recurrence.Changes
src/model/nest-logger.spec.ts(new) — Unit tests for all fiveNestLoggermethods (error,warn,log,debug,verbose), each asserting arguments arrive as a flat array at the transport layer:test/mock-log.transport.ts— ReplacedlogArgs: anywith a typedMockLogArgsinterface, eliminating unsafe member access lint errors surfaced by the new tests.✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.