feat: update Node.js version and dependencies, use rolldown, enhance configurations, fix lint issues#28
Merged
mumenthalers merged 1 commit intomasterfrom Mar 17, 2026
Conversation
9fa26cb to
cf0b101
Compare
There was a problem hiding this comment.
Pull request overview
This PR modernizes the action’s toolchain by bumping the Node.js baseline to v24, migrating the build output from ncc to rolldown, and introducing updated formatting/linting/commit tooling aligned with newer ESLint + TypeScript conventions.
Changes:
- Update runtime/tooling to Node.js 24 (engines, action runtime, CI workflow, TS target).
- Replace
nccbuild withrolldownand add/refresh repo-wide Prettier, ESLint (flat config), lint-staged, and commitlint configs. - Fix lint/type issues by tightening TS annotations and adjusting execution style (top-level
await).
Reviewed changes
Copilot reviewed 18 out of 21 changed files in this pull request and generated 7 comments.
Show a summary per file
| File | Description |
|---|---|
tsconfig.json |
Updates TS target to ES2024 and normalizes exclude formatting. |
src/lab.ts |
Adds top-level await and tightens typing for URL param / Octokit response. |
src/index.ts |
Adds top-level await, adds lint suppression for GitHub payload access, tightens fetch param types. |
prettier.config.js |
Introduces JS-based (ESM) Prettier configuration. |
package.json |
Updates Node engine, deps, and switches build script to rolldown; adds CI format/lint scripts. |
lint-staged.config.js |
Adds lint-staged configuration for formatting/linting staged files. |
eslint.config.js |
Migrates to ESLint flat config with type-aware TypeScript rules. |
commitlint.config.js |
Adds commitlint JS config. |
action.yml |
Bumps action runtime to node24. |
README.md |
Reformats workflow/docs content and updates development section formatting. |
.prettierrc.yml |
Removes legacy Prettier YAML config in favor of JS config. |
.prettierignore |
Ignores dist for formatting. |
.nvmrc |
Updates local Node version to 24. |
.npmrc |
Disables funding prompts. |
.lintstagedrc.yml |
Removes legacy lint-staged YAML config in favor of JS config. |
.husky/pre-commit |
Converts pre-commit hook to multi-line script and keeps building dist. |
.github/workflows/test.yml |
Updates CI to use .nvmrc, adds formatting and linting checks, pins actions by SHA. |
.eslintrc.yml |
Removes legacy ESLint YAML config in favor of flat config. |
.commitlintrc.yml |
Removes legacy commitlint YAML config in favor of JS config. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
…configurations, fix lint issues
cf0b101 to
e6df3ba
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.