Open
Conversation
Collaborator
|
Thanks, I will have a look and we can discuss next week |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I tried to improve the
networkclass a little bit. @IngoScholtes , we should have a look at it when you are back.degree(),in_degree(),out_degree(),weight(),in_weight(),out_weight().add_node(),remove_node(),add_edge()and added the methodremove_edge()for a better readability.@propertyfor the propertiesdirected,vcount,ecount,weighted,total_edge_weight. This makes also sure that properties likedirectedcannot easily be changed.in_edges()andout_edges()which obtain all in- respectively out-edges of a given node.to_directed()andto_undirected()which convert network into directed / undirected network.read_nodes()andwrite_nodes()which read / write node data to a file.Rewrote methods
read_edges()andwrite_edges()such that they also read / store edge attributes.