Skip to content

Issue 26: Close mobile nav on navigation #34

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
TommyOh0428 merged 1 commit into from
Jan 8, 2025
Merged

Issue 26: Close mobile nav on navigation #34

TommyOh0428 merged 1 commit into from
Jan 8, 2025

Conversation

@bnquon
Copy link
Contributor

@bnquon bnquon commented Dec 23, 2024

  • Add re-render to close nav menu on location.pathname change
  • Won't do anything if user clicks same page they're already on.

#26

@bnquon bnquon linked an issue Dec 23, 2024 that may be closed by this pull request
Close the slide out menu on navigation to new route (mobile view) #26
Closed
@bnquon bnquon requested a review from Seanspoons December 23, 2024 23:52
@TommyOh0428 TommyOh0428 merged commit 2f58c42 into main Jan 8, 2025
5 checks passed
@TommyOh0428 TommyOh0428 deleted the 26-close-the-slide-out-menu-on-navigation-to-new-route-mobile-view branch January 8, 2025 04:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@TommyOh0428 TommyOh0428 TommyOh0428 approved these changes

@Seanspoons Seanspoons Awaiting requested review from Seanspoons

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Close the slide out menu on navigation to new route (mobile view)

3 participants

@bnquon @TommyOh0428