Fixes a crash where getProProof is called on a wrong object#42
Merged
SessionHero01 merged 1 commit intomainfrom Mar 3, 2026
Merged
Fixes a crash where getProProof is called on a wrong object#42SessionHero01 merged 1 commit intomainfrom
SessionHero01 merged 1 commit intomainfrom
Conversation
|
The build version for this PR will be: |
ThomasSession
approved these changes
Feb 26, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Basically when we get and cache a method ID for Conversation subclasses, we actually got the method ID for the concrete classes, instead of the interface (
WithProProofInfo)'s method. Next time the same method ID is called on another subclass, it crashes the app because wrong object type is called on.This change makes sure that the method of
getProProofInfois from the interface class instead.