perf: use NonZeroU32 for query and fragment start#933
Open
DonIsaac wants to merge 5 commits intoservo:mainfrom
Open
perf: use NonZeroU32 for query and fragment start#933DonIsaac wants to merge 5 commits intoservo:mainfrom
DonIsaac wants to merge 5 commits intoservo:mainfrom
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #933 +/- ##
=======================================
Coverage ? 81.78%
=======================================
Files ? 21
Lines ? 3574
Branches ? 0
=======================================
Hits ? 2923
Misses ? 651
Partials ? 0 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Author
|
@valenting may I please have a review on this? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #930 and addresses feedback #931.
Reduces
Urlmemory layout from 88 bytes to 80 bytes.