Skip to content

Simplify parse_nth by delegating directly to parse_b and parse_signless_b #422

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
emilio merged 1 commit into from
Dec 25, 2025
Merged

Simplify parse_nth by delegating directly to parse_b and parse_signless_b #422

emilio merged 1 commit into from
Dec 25, 2025
+6 −6

Conversation

@nnabeyang
Copy link
Contributor

@nnabeyang nnabeyang commented Dec 25, 2025

This PR fixes redundant result wrapping in parse_nth. Previously, calls to
parse_b and parse_signless_b were wrapped inside Ok(...), even though
those helpers already return Result<(i32, i32), BasicParseError>.

emilio
emilio approved these changes Dec 25, 2025
View reviewed changes
Copy link
Member

@emilio emilio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@emilio emilio added this pull request to the merge queue Dec 25, 2025
Merged via the queue into servo:main with commit 8fc7a5c Dec 25, 2025
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@emilio emilio emilio approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@nnabeyang @emilio