Skip to content

Conversation

@arminhammer
Copy link
Contributor

@arminhammer arminhammer commented Dec 12, 2025

Please specify parts of this PR update:

  • Specification
  • Schema
  • Examples
  • Extensions
  • Use Cases
  • Community
  • CTK
  • Other

Discussion or Issue link:

#1135

What this PR does:

This PR proposes some fixes to the extension example in dsl.md, as well as the extension reference section in dsl-reference.md. These fixes are designed to align the spec with the discrepancies addressed in #1135.

Additional information:

Copilot AI review requested due to automatic review settings December 12, 2025 04:25
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR fixes the extension examples and reference documentation to correctly represent extensions as an array rather than a map, addressing discrepancies identified in issue #1135.

  • Changed extensions from map[string, extension] to extension[] in the reference documentation
  • Updated the extension example in dsl.md to use array syntax
  • Corrected the before and after property types from map[string, task] to task[] in the extension reference

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.

File Description
dsl.md Updated the extension example to use array syntax (with list item prefix -) instead of map syntax
dsl-reference.md Updated the extensions type from map[string, extension] to extension[] and corrected before/after properties from map[string, task] to task[]

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copy link
Member

@ricardozanini ricardozanini left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like Copilot is useful. :)

@arminhammer can you take a look at the Copilot suggestions? The property indeed is named endpoint.

Signed-off-by: Armin Graf <arminhammer@gmail.com>
Signed-off-by: Armin Graf <arminhammer@gmail.com>
@arminhammer
Copy link
Contributor Author

Looks like Copilot is useful. :)

@arminhammer can you take a look at the Copilot suggestions? The property indeed is named endpoint.

Interesting! My change was ultimately a formatting change, but it caused Copilot to take another look and spot the latent error. Useful indeed.

In any case, I fixed the issue and changed uri to endpoint, to align with the spec.

Copy link
Member

@cdavernas cdavernas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Cheers ❤️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants