Conversation
toshimaru
force-pushed
the
update-gemspec
branch
from
9358887 to
a86a641
Compare
There was a problem hiding this comment.
Pull Request Overview
This PR updates the gem and CI configuration to support Ruby v3.4 and aligns repository links with the serverkit organization. Key changes include:
- Replacing manual library path manipulations with require_relative in both the gemspec and library files.
- Updating repository URLs in the gemspec and README.
- Updating the Ruby version matrix in the CI workflow and adjusting license and contributing sections.
- Removing the CODE_OF_CONDUCT.md file.
Reviewed Changes
Copilot reviewed 7 out of 7 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| serverkit-vscode.gemspec | Updated require statement and repository homepage URL |
| lib/serverkit/vscode.rb | Switched to require_relative for module version/resource loading |
| README.md | Updated GitHub links and restructured License/Contributing sections |
| LICENSE.txt | Updated copyright year |
| CODE_OF_CONDUCT.md | Removed the file from the repository |
| .github/workflows/test.yml | Updated job name and Ruby version matrix to include Ruby 3.4 |
Comments suppressed due to low confidence (1)
CODE_OF_CONDUCT.md:1
- The removal of the Code of Conduct file may affect community guidelines; please confirm that this removal is intentional and update any references accordingly.
# Contributor Covenant Code of Conduct
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request introduces several updates across the project, including renaming workflows, updating dependencies, modifying repository references, and removing the code of conduct. Below is a summary of the most important changes grouped by theme.
Workflow and Dependency Updates:
rspecjob totestin.github/workflows/test.ymland added Ruby 3.4 to the test matrix. (.github/workflows/test.yml)Repository and Metadata Updates:
README.mdandserverkit-vscode.gemspecto reflect the new organization (serverkit/serverkit-vscode) instead of the previous one (toshimaru/serverkit-vscode). [1] [2]$LOAD_PATHmodification and switched torequire_relativefor internal file imports inlib/serverkit/vscode.rbandserverkit-vscode.gemspec. [1] [2]Documentation Changes:
CODE_OF_CONDUCT.mdfile entirely from the repository.README.mdto include a "Contributing" section, replacing the reference to the removed code of conduct.Licensing Update:
LICENSE.txtfrom2019-2024to2025.These changes collectively improve the project's structure, update documentation, and align the repository with the new organization.