Merged
Conversation
grep latest version using `mise latest name`.
318323d to
fbc91f0
Compare
There was a problem hiding this comment.
Pull Request Overview
This PR fixes the latest version check command by updating the grep command to properly use the latest version when no specific version is provided.
- Updates the check method to conditionally use the version if set
- Replaces the original
version_or_latestmethod with direct string interpolation in the command
Comments suppressed due to low confidence (1)
lib/serverkit/resources/mise_install.rb:21
- [nitpick] Consider using a consistent quoting style for the grep pattern across both branches of the conditional to enhance readability and reduce potential confusion.
"$(mise latest #{name})"
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
grep latest version using
mise latest name.mise install yarn: