Conversation
toshimaru
force-pushed
the
fix-version-grep
branch
from
18794ae to
c4608ed
Compare
`install yarn@1` should match major version of the version. ``` [SKIP] mise_use node on localhost Running mise ls yarn | grep '\s1' on localhost yarn 1.22.22 ```
toshimaru
force-pushed
the
fix-version-grep
branch
from
c4608ed to
d53c0f2
Compare
toshimaru
changed the title
There was a problem hiding this comment.
Pull Request Overview
This PR aims to fix the version matching in the grep command by ensuring that only versions with a proper prefix (whitespace) are matched.
- Updated grep command to match whitespace preceding the version string.
- Removed an extra space before "mise ls" in the command.
Comments suppressed due to low confidence (1)
lib/serverkit/resources/mise_install.rb:18
- Consider verifying that the '\s' shorthand is supported in the target grep environment. If portability is a concern, you might use a POSIX character class such as '[[:space:]]' instead.
check_command("mise ls #{name} | grep '\s#{version_or_latest}'")
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
grep version with version prefix.