🔒 Improve AWS Cloud IAM policy security #839
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -83,11 +83,21 @@ The following permissions are required to provision resources in the AWS account | |
| "iam:CreateInstanceProfile", | ||
| "iam:AttachRolePolicy", | ||
| "iam:PutRolePolicy", | ||
| "iam:TagRole", | ||
| "iam:TagInstanceProfile" | ||
| ], | ||
| "Resource": [ | ||
| "arn:aws:iam::*:role/TowerForge-*", | ||
| "arn:aws:iam::*:instance-profile/TowerForge-*" | ||
| ] | ||
| }, | ||
| { | ||
| "Sid": "AwsCloudCreatePassRole", | ||
| "Effect": "Allow", | ||
| "Action": [ | ||
| "iam:PassRole" | ||
| ], | ||
| "Resource": "arn:aws:iam::*:role/TowerForge-*" | ||
| } | ||
| ] | ||
| } | ||
|
|
@@ -124,15 +134,49 @@ The following permissions are required to launch pipelines, run Studio sessions, | |
| "Version": "2012-10-17", | ||
| "Statement": [ | ||
| { | ||
| "Sid": "AwsCloudLaunchEC2", | ||
| "Effect": "Allow", | ||
| "Action": [ | ||
| "ec2:RunInstances", | ||
| "ec2:CreateTags", | ||
| "ec2:DeleteTags" | ||
| ], | ||
| "Resource": [ | ||
| "arn:aws:ec2:*:*:instance/*", | ||
| "arn:aws:ec2:*:*:volume/*", | ||
| "arn:aws:ec2:*:*:network-interface/*", | ||
| "arn:aws:ec2:*:*:subnet/*", | ||
| "arn:aws:ec2:*:*:security-group/*", | ||
| "arn:aws:ec2:*:*:key-pair/*", | ||
| "arn:aws:ec2:*:*:image/*" | ||
| ] | ||
| }, | ||
| { | ||
| "Sid": "AwsCloudLaunchInstances", | ||
| "Effect": "Allow", | ||
| "Action": [ | ||
| "ec2:DescribeInstances", | ||
|
Contributor
There was a problem hiding this comment. Did you test this? AWS Docs say that using the
Contributor
There was a problem hiding this comment. @kenibrewer, following up on this so we can merge this PR. :) |
||
| "ec2:TerminateInstances" | ||
| ], | ||
| "Resource": "*", | ||
| "Condition": { | ||
| "StringLike": { | ||
| "ec2:ResourceTag/Name": "TowerForge-*" | ||
| } | ||
| } | ||
| }, | ||
| { | ||
| "Sid": "AwsCloudLaunchLogs", | ||
| "Effect": "Allow", | ||
| "Action": [ | ||
| "logs:GetLogEvents" | ||
| ], | ||
| "Resource": "arn:aws:logs:*:*:log-group:*:log-stream:*" | ||
justinegeffen marked this conversation as resolved.
Show resolved
Hide resolved
|
||
| }, | ||
| { | ||
| "Sid": "AwsCloudLaunchS3", | ||
| "Effect": "Allow", | ||
| "Action": [ | ||
| "s3:GetObject" | ||
| ], | ||
| "Resource": "*" | ||
justinegeffen marked this conversation as resolved.
Show resolved
Hide resolved
|
||
|
|
@@ -162,7 +206,10 @@ The following permissions are required to remove resources created by Seqera whe | |
| "iam:DetachRolePolicy", | ||
| "iam:DeleteRolePolicy" | ||
| ], | ||
| "Resource": [ | ||
| "arn:aws:iam::*:role/TowerForge-*", | ||
| "arn:aws:iam::*:instance-profile/TowerForge-*" | ||
| ] | ||
| } | ||
| ] | ||
| } | ||
|
|
||
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this really any different than using
*? Actions are anyhow not applicable to all resource types, so defining individual resource types still with a star permission doesn't seem to change much the scope of the actual permissions.For example, with the current config I can't use
ec2:RunInstanceson a Kinesis stream, because the action already carries the scope of what resource type it can be taken against.On the other hand I get this might have a placebo effect if someone reads it through without giving it much thought, it seems more scoped.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can this be addressed in a separate PR? Or is it a blocker to merging this PR?