Skip to content

[WIP] Loosen alphabet_variant requirement #3342

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
eseiler wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

[WIP] Loosen alphabet_variant requirement #3342

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
22 changes: 13 additions & 9 deletions include/seqan3/alphabet/composite/alphabet_variant.hpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -121,18 +121,22 @@ template <typename... alternative_types>
requires (detail::writable_constexpr_alphabet<alternative_types> && ...) && (std::regular<alternative_types> && ...)
&& (sizeof...(alternative_types) >= 2)
class alphabet_variant :
public alphabet_base<alphabet_variant<alternative_types...>,
(static_cast<size_t>(alphabet_size<alternative_types>) + ...),
char>
public alphabet_base<
alphabet_variant<alternative_types...>,
(static_cast<size_t>(alphabet_size<alternative_types>) + ...),
std::conditional_t<(std::same_as<alphabet_char_t<alternative_types>, char> && ...), char, char16_t>>
{
private:
//!\brief The base type.
using base_t = alphabet_base<alphabet_variant<alternative_types...>,
(static_cast<size_t>(alphabet_size<alternative_types>) + ...),
char>;

static_assert((std::is_same_v<alphabet_char_t<alternative_types>, char> && ...),
"The alphabet_variant is currently only tested for alphabets with char_type char. "
using base_t = alphabet_base<
alphabet_variant<alternative_types...>,
(static_cast<size_t>(alphabet_size<alternative_types>) + ...),
std::conditional_t<(std::same_as<alphabet_char_t<alternative_types>, char> && ...), char, char16_t>>;

static_assert(((std::is_same_v<alphabet_char_t<alternative_types>, char>
|| std::is_same_v<alphabet_char_t<alternative_types>, char16_t>)
&& ...),
"The alphabet_variant is currently only tested for alphabets with char_type char or char16_t. "
"Contact us on GitHub if you have a different use case: https://github.com/seqan/seqan3 .");

//!\brief Befriend the base type.
Expand Down