Conversation
|
Thanks for the PR. At the moment, the PR doesn't follow our current design pattern. All of our variables are defined at the top level. And although they could arguable be put elsewhere, I believe it's better to hold onto one standard, albeit a little outdated, then to put them all over the place. Wouldn't it be better to manage the service itself then to not manage it entirely? For example, you could ensure the service is not running if that is what you prefer. However, if that is the case, this isn't 100% complete yet as you need to change We're also missing some tests and documentation. We require both to merge this PR. |
|
Thanks for your feedback. I am currently modifying my code, which will hopefully cover your comments. I will update the code first and if you like it I will adjust the rspec and documentation once you are satisfied with the code. Hopefully your okay with this? |
|
Sounds good! |
|
What is the status of this PR? It looks very usefull though! |
|
@mkjmdski Sorry for the late answer, although I am still willing to make the changes to the code so that it meets the standards required by this module, Corona has delayed some things. |
I needed a way to disable servers which I didn't need.
The following three services are able to be turned off.