Skip to content

Conversation

@OnestarLee
Copy link
Contributor

@OnestarLee OnestarLee commented Jan 21, 2026

Summary

  • Fixed a bug where the delete channel modal did not close after successful deletion
  • Added channel event handler to OpenChannelList to listen for channel deletion events and update the list automatically
  • Fixed the OpenChannelApp to properly handle channel deletion by closing settings and clearing the selected channel

Ticket

https://sendbird.atlassian.net/browse/CLNP-7730

Changelogs

  • Fixed a bug where the open channel delete modal did not close after successful deletion
  • Fixed a bug where the open channel list was not updated after a channel was deleted

Checklist

  • All tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works
  • Public components / utils / props are appropriately exported
  • I have added necessary documentation (if appropriate)

@netlify
Copy link

netlify bot commented Jan 21, 2026

Deploy Preview for sendbird-uikit-react ready!

Name Link
🔨 Latest commit ada4aa8
🔍 Latest deploy log https://app.netlify.com/projects/sendbird-uikit-react/deploys/6970494f4eeca4000841c3bb
😎 Deploy Preview https://deploy-preview-1390--sendbird-uikit-react.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This pull request fixes a bug where the delete channel modal did not close after successful deletion and the channel list was not updated to reflect the deletion. The fix adds event handling for channel deletion and ensures proper UI state management.

Changes:

  • Added channel deletion event handler to OpenChannelList to automatically update the list when a channel is deleted
  • Fixed DeleteOpenChannel modal to close after successful deletion and migrated from deprecated onCancel to onClose prop
  • Added onDeleteChannel callback to OpenChannelApp to close settings panel and clear selected channel on deletion

Reviewed changes

Copilot reviewed 6 out of 6 changed files in this pull request and generated 1 comment.

Show a summary per file
File Description
src/modules/OpenChannelSettings/components/OperatorUI/DeleteOpenChannel.tsx Closes modal after successful deletion and migrates to non-deprecated onClose prop
src/modules/OpenChannelList/context/dux/reducer.ts Adds DELETE_OPEN_CHANNEL action handler to filter deleted channel from list and clear currentChannel if needed
src/modules/OpenChannelList/context/dux/actionTypes.ts Adds DELETE_OPEN_CHANNEL action type enum
src/modules/OpenChannelList/context/OpenChannelListProvider.tsx Adds OpenChannelHandler to listen for channel deletion events and dispatch DELETE_OPEN_CHANNEL action
src/modules/OpenChannelApp/index.tsx Adds onDeleteChannel callback to close settings and clear channel URL when channel is deleted
.nvmrc Adds Node.js version specification (18) matching package.json requirements

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@OnestarLee OnestarLee force-pushed the bug-fix/CLNP-7730-open-channel-delete-modal-and-list-not-updating branch from 20f68e5 to ada4aa8 Compare January 21, 2026 03:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants