Skip to content

Use Codex app-server install and drop global rescue agent#15

Merged
sf-jin-ku merged 2 commits intomainfrom
jin/codex-app-server-hooks-only-readme
Apr 6, 2026
Merged

Use Codex app-server install and drop global rescue agent#15
sf-jin-ku merged 2 commits intomainfrom
jin/codex-app-server-hooks-only-readme

Conversation

@sf-jin-ku
Copy link
Copy Markdown
Contributor

Summary

  • install and uninstall through Codex app-server when available, with safe fallback activation on unsupported builds
  • remove the global cc-rescue agent and keep only managed Codex hooks outside the plugin directory
  • switch rescue to the built-in forwarding subagent path, harden self-clean behavior, and document unread background-result nudges

Testing

  • node --test tests/install-hooks.test.mjs tests/installer-cli.test.mjs tests/render.test.mjs tests/e2e/codex-skills-e2e.test.mjs tests/skills-contracts.test.mjs tests/unread-result-hook.test.mjs

@sf-jin-ku sf-jin-ku merged commit 6bb9023 into main Apr 6, 2026
3 checks passed
Copy link
Copy Markdown

@chatgpt-codex-connector chatgpt-codex-connector bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 60d5b031aa

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".


if (changed) {
writeConfigFile(nextContent);
const pluginRemoval = removeTomlSections(existing, new Set([PLUGIN_CONFIG_HEADER]));
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Badge Remove legacy managed cc-rescue registration during uninstall

This uninstall cleanup now removes only [plugins."cc@local-plugins"], so users upgrading from earlier releases keep the previously managed cc-rescue global-agent artifacts ([agents."cc-rescue"] in config.toml and ~/.codex/agents/cc-rescue.toml). After uninstall deletes the plugin directory, that leftover agent registration becomes stale and can still surface a broken rescue agent path; uninstall should also prune the managed legacy agent block/file (while leaving user-customized agent entries intact).

Useful? React with 👍 / 👎.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant