fix(faults): enable real-time toast notifications for SSE fault events#29
Merged
mfaferek93 merged 1 commit intomainfrom Feb 1, 2026
Merged
Conversation
There was a problem hiding this comment.
Pull request overview
Enables real-time fault toast notifications by subscribing to the gateway’s SSE fault stream on connect and handling the gateway’s named SSE events/payload shape.
Changes:
- Subscribe to the faults SSE stream on connect and unsubscribe on disconnect.
- Update SSE parsing to support gateway payload shape
{ event_type, fault, timestamp }. - Listen for named SSE events (
fault_confirmed,fault_cleared) with a known-events fallback.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| src/lib/store.ts | Hooks fault stream subscription lifecycle into connect/disconnect. |
| src/lib/sovd-api.ts | Updates SSE subscription to handle named events and unwrap nested fault payloads. |
347c3c8 to
fe23e3a
Compare
- Subscribe to fault SSE stream on connect, unsubscribe on disconnect
- Listen for named SSE events (fault_confirmed, fault_cleared)
- Handle confirmed and cleared events separately:
- fault_confirmed: add/update fault, show warning toast
- fault_cleared: remove fault from list, show success toast
- Extract fault data from SSE payload structure { event_type, fault, timestamp }
fe23e3a to
8bb159c
Compare
bburda
approved these changes
Feb 1, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request
Summary
Issue
Link the related issue (required):
Type
Testing
How was this tested / how should reviewers verify it?
Checklist
npm run lint)npm run build)