Skip to content

One call to ApplyChangeSets per block#3533

Draft
cody-littley wants to merge 3 commits into
mainfrom
cjl/one-diff-per-block
Draft

One call to ApplyChangeSets per block#3533
cody-littley wants to merge 3 commits into
mainfrom
cjl/one-diff-per-block

Conversation

@cody-littley
Copy link
Copy Markdown
Contributor

Describe your changes and provide context

Things can be simplified greatly (in future PRs) if we limit calls to ApplyChangeSets() to once per block. Current code calls this method with empty change sets sometimes, and the code required to support this is extremely nontrivial.

@github-actions
Copy link
Copy Markdown

github-actions Bot commented Jun 2, 2026

The latest Buf updates on your PR. Results from workflow Buf / buf (pull_request).

BuildFormatLintBreakingUpdated (UTC)
✅ passed✅ passed✅ passed✅ passedJun 2, 2026, 4:56 PM

@codecov
Copy link
Copy Markdown

codecov Bot commented Jun 2, 2026

Codecov Report

❌ Patch coverage is 91.54930% with 12 lines in your changes missing coverage. Please review.
✅ Project coverage is 58.68%. Comparing base (f8f1af1) to head (8dfea0c).
⚠️ Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
sei-db/state_db/sc/migration/router_builder.go 89.79% 10 Missing ⚠️
sei-cosmos/storev2/rootmulti/store.go 77.77% 1 Missing and 1 partial ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #3533      +/-   ##
==========================================
- Coverage   59.12%   58.68%   -0.45%     
==========================================
  Files        2213     2170      -43     
  Lines      182774   178142    -4632     
==========================================
- Hits       108072   104537    -3535     
+ Misses      64985    64223     -762     
+ Partials     9717     9382     -335     
Flag Coverage Δ
sei-chain-pr 62.88% <77.77%> (?)
sei-db 70.41% <ø> (ø)
sei-db-state-db ?
sei-db-state-db-pr 77.25% <92.48%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
sei-db/state_db/sc/flatkv/store.go 76.94% <ø> (ø)
sei-db/state_db/sc/flatkv/store_apply.go 91.78% <100.00%> (+0.12%) ⬆️
sei-db/state_db/sc/flatkv/store_write.go 76.92% <100.00%> (-1.13%) ⬇️
...ei-db/state_db/sc/migration/accumulating_writer.go 100.00% <100.00%> (ø)
sei-db/state_db/sc/migration/flushing_router.go 100.00% <100.00%> (ø)
sei-cosmos/storev2/rootmulti/store.go 65.21% <77.77%> (+0.12%) ⬆️
sei-db/state_db/sc/migration/router_builder.go 62.92% <89.79%> (+6.20%) ⬆️

... and 46 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant