Tests: rpc initial setup and rpc tests phase 1#3520
Conversation
PR SummaryLow Risk Overview Harness: Mocha + tsx configs for sequential bootstrap vs sharded runs, env-driven endpoints, compile-only Hardhat, gitignored runtime state, and docs for Bootstrap ( Phase 1 Reviewed by Cursor Bugbot for commit 2a9e78a. Bugbot is set up for automated code reviews on this repo. Configure here. |
|
The latest Buf updates on your PR. Results from workflow Buf / buf (pull_request).
|
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes using default effort and found 3 potential issues.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit f1a394f. Configure here.
| describe('empty / null handling', () => { | ||
| it('a keyless node returns [] (empty array), never null', async function () { | ||
| const body = await rawAccountless<string[]>('eth_accounts', []); | ||
| console.log(body); |
There was a problem hiding this comment.
Debug console.log left in test code
Low Severity
A console.log(body) statement is left in the "keyless node returns []" test. This dumps the full raw JSON-RPC response body to stdout on every run, cluttering test output and potentially leaking response details into CI logs.
Reviewed by Cursor Bugbot for commit f1a394f. Configure here.
| const err = expectJsonRpcError(s, 3, /execution reverted/i); | ||
| expect(err.data).to.equal( | ||
| '0x96c6fd1e0000000000000000000000000000000000000000000000000000000000000000', | ||
| ); |
There was a problem hiding this comment.
Revert data assertion mismatches TestERC20 contract output
Medium Severity
The test asserts err.data equals 0x96c6fd1e..., but the TestERC20 contract uses require(balanceOf[from] >= value, "ERC20: insufficient balance") with a string message. This produces Error(string) revert data with selector 0x08c379a0, not 0x96c6fd1e. The custom-error require syntax is a different overload (Solidity 0.8.26+ via-ir only) and is not used here. This assertion will fail at runtime.
Reviewed by Cursor Bugbot for commit f1a394f. Configure here.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #3520 +/- ##
==========================================
- Coverage 59.03% 58.21% -0.82%
==========================================
Files 2199 2129 -70
Lines 182207 174079 -8128
==========================================
- Hits 107569 101346 -6223
+ Misses 64975 63729 -1246
+ Partials 9663 9004 -659
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|


Describe your changes and provide context
Testing performed to validate your change