-
Notifications
You must be signed in to change notification settings - Fork 862
Adjusted RPC http requests to use POST instead of GET #2675
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
The latest Buf updates on your PR. Results from workflow Buf / buf (pull_request).
|
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2675 +/- ##
=======================================
Coverage 43.80% 43.81%
=======================================
Files 1907 1907
Lines 158902 158902
=======================================
+ Hits 69613 69628 +15
+ Misses 82899 82877 -22
- Partials 6390 6397 +7
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
|
@masih @sei-will just on the PR above, I noticed CMD |
masih
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Left a set of suggestions. Specifically, having tests depend on remote endpoint by default is the one blocker.
Thanks for getting this sorted @monty-sei 🍻
masih
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No blockers, left some suggestions. Nice work @monty-sei
Also please feel free to resolve the review comments that are fixed directly without replies 👍
… for server responses. Converted interface{} to any.
|
@masih does the team prefer to run rebases or merges for outdated branches? I'm a big fan of rebasing vs merge but wanted to check first! |
Squash merge only I'm afraid. I also am an advocate for rebase but that works well when almost all PRs have a single commit with a clear message. |
RPC calls for the EVM CLI were attempting to send methods via GET instead of POST, resulting in failed extraction of results from the associated RPC calls as none were being returned. Adjustments to `getChainId()`, `getNonce()` and `CmdAssociateAddress()` were made NOTE: the latter `CmdAssociateAddress` had an internal cmd method call to `sei_associate` using GET instead of POST. Fixes REL-107 (cherry picked from commit 7c036d1)
|
Successfully created backport PR for |
RPC calls for the EVM CLI were attempting to send methods via GET instead of POST, resulting in failed extraction of results from the associated RPC calls as none were being returned.
Adjustments to
getChainId(),getNonce()andCmdAssociateAddress()were madeNOTE: the latter
CmdAssociateAddresshad an internal cmd method call tosei_associateusing GET instead of POST.Fixes REL-107