Skip to content

Conversation

@monty-sei
Copy link
Contributor

RPC calls for the EVM CLI were attempting to send methods via GET instead of POST, resulting in failed extraction of results from the associated RPC calls as none were being returned.

Adjustments to getChainId(), getNonce() and CmdAssociateAddress() were made

NOTE: the latter CmdAssociateAddress had an internal cmd method call to sei_associate using GET instead of POST.

Fixes REL-107

@github-actions
Copy link

github-actions bot commented Jan 8, 2026

The latest Buf updates on your PR. Results from workflow Buf / buf (pull_request).

BuildFormatLintBreakingUpdated (UTC)
✅ passed✅ passed✅ passed✅ passedJan 12, 2026, 10:03 AM

@masih masih requested a review from sei-will January 8, 2026 12:11
@codecov
Copy link

codecov bot commented Jan 8, 2026

Codecov Report

❌ Patch coverage is 66.66667% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 43.81%. Comparing base (14f8cf3) to head (767df69).
⚠️ Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
x/evm/client/cli/tx.go 66.66% 1 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #2675   +/-   ##
=======================================
  Coverage   43.80%   43.81%           
=======================================
  Files        1907     1907           
  Lines      158902   158902           
=======================================
+ Hits        69613    69628   +15     
+ Misses      82899    82877   -22     
- Partials     6390     6397    +7     
Flag Coverage Δ
sei-chain 45.87% <66.66%> (+0.02%) ⬆️
sei-cosmos 38.20% <ø> (-0.01%) ⬇️
sei-db 69.43% <ø> (ø)
sei-tendermint 47.33% <ø> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
x/evm/client/cli/tx.go 4.69% <66.66%> (+4.69%) ⬆️

... and 10 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@monty-sei
Copy link
Contributor Author

@masih @sei-will just on the PR above, I noticed CMD CmdAssociateAddress was running an RPC call via GET as well, which would result in an incorrect response. Now the actual CMD doesn't use the response other than printing out the result, so no errors would actually occur. I've adjusted this to use POST to remove incorrect logic, but let me know your thoughts on this as the actual method call sei_associate and the association functionality is one I'm not familiar with yet

Copy link
Collaborator

@masih masih left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left a set of suggestions. Specifically, having tests depend on remote endpoint by default is the one blocker.

Thanks for getting this sorted @monty-sei 🍻

@monty-sei monty-sei requested a review from masih January 9, 2026 01:22
Copy link
Collaborator

@masih masih left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No blockers, left some suggestions. Nice work @monty-sei

Also please feel free to resolve the review comments that are fixed directly without replies 👍

… for server responses. Converted interface{} to any.
@monty-sei
Copy link
Contributor Author

@masih does the team prefer to run rebases or merges for outdated branches? I'm a big fan of rebasing vs merge but wanted to check first!

@masih
Copy link
Collaborator

masih commented Jan 12, 2026

does the team prefer to run rebases or merges for outdated branches? I'm a big fan of rebasing vs merge but wanted to check first!

Squash merge only I'm afraid. I also am an advocate for rebase but that works well when almost all PRs have a single commit with a clear message.

@masih masih enabled auto-merge (squash) January 12, 2026 10:38
@masih masih merged commit 7c036d1 into main Jan 12, 2026
39 checks passed
@masih masih deleted the monty-sei/seid-cli-evm-command-fix branch January 12, 2026 10:48
github-actions bot pushed a commit that referenced this pull request Jan 12, 2026
RPC calls for the EVM CLI were attempting to send methods via GET
instead of POST, resulting in failed extraction of results from the
associated RPC calls as none were being returned.

Adjustments to `getChainId()`, `getNonce()` and `CmdAssociateAddress()`
were made

NOTE: the latter `CmdAssociateAddress` had an internal cmd method call
to `sei_associate` using GET instead of POST.

Fixes REL-107

(cherry picked from commit 7c036d1)
@github-actions
Copy link

Successfully created backport PR for release/v6.3:

masih pushed a commit that referenced this pull request Jan 16, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants