-
Notifications
You must be signed in to change notification settings - Fork 862
[giga] abstract occ scheduler into interfaces #2610
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
cce0d85 to
6e47c9c
Compare
|
The latest Buf updates on your PR. Results from workflow Buf / buf (pull_request).
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #2610 +/- ##
==========================================
+ Coverage 43.23% 48.35% +5.11%
==========================================
Files 1851 682 -1169
Lines 152771 59854 -92917
==========================================
- Hits 66055 28943 -37112
+ Misses 80835 28499 -52336
+ Partials 5881 2412 -3469
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
6e47c9c to
1c987dd
Compare
|
We truly appreciate your contribution and the time you’ve invested in this PR. |
Describe your changes and provide context
The existing OCC scheduler is somewhat coupled with Cosmos specific logics like
sdk.Contextand stores. This PR refactors the scheduler to be generic and not dependent on any Cosmos specific types, so that it can later be used for giga execution. Specifically this PR yields the following two interfaces for giga to implement and use:Testing performed to validate your change
refactor - existing tests should still hold