script_debug: expose SigVersion in callback#145
Open
febyeji wants to merge 3 commits intosedited:feature_script_debugfrom
Open
script_debug: expose SigVersion in callback#145febyeji wants to merge 3 commits intosedited:feature_script_debugfrom
febyeji wants to merge 3 commits intosedited:feature_script_debugfrom
Conversation
febyeji
force-pushed
the
script-debug/sigversion
branch
from
4a6d93b to
24b9e8f
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
SigVersion(BASE/WITNESS_V0/TAPROOT/TAPSCRIPT) in the debug callbackSigVersionenum to Rust bindings withTryFrom<u8>Tests
test_script_debug: assertsSigVersion::Basefor P2PKH framesDepends on #143 and #144.