Skip to content
This repository was archived by the owner on Feb 26, 2021. It is now read-only.

Commit 5268f52

Browse files
Daniel PataninDaniel Patanin
authored andcommitted
minor changes
1 parent 55e497f commit 5268f52

File tree

3 files changed

+4
-4
lines changed

3 files changed

+4
-4
lines changed

scb-engine/src/main/resources/application-dev.yaml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -15,5 +15,5 @@ securecodebox.rest.user.scanner-default:
1515
password: scan
1616

1717
securecodebox.persistence.defectdojo.baseurl: http://localhost:8000
18-
securecodebox.persistence.defectdojo.apikey: 6fd1b5e90d7afa33d1da939d7d51a9b745b11660
18+
securecodebox.persistence.defectdojo.apikey:
1919

scb-persistenceproviders/defectdojo-persistenceprovider/src/main/java/io/securecodebox/persistence/DefectDojoPersistenceProvider.java

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -198,7 +198,8 @@ protected static String getDefectDojoScanName(String securityTestName) {
198198
scannerDefectDojoMapping.put("nmap", "Nmap Scan");
199199
scannerDefectDojoMapping.put("zap", "ZAP Scan");
200200

201-
// TODO: Why is nikto not in the list?
201+
// Nikto is a supported tool as well but currently not accessible for supported import.
202+
// Nikto thus will use Generic Findings Import.
202203

203204
// Can be used by 3rd party integrations to
204205
// import these scan results directly into defectdojo
@@ -225,7 +226,6 @@ protected static String getDefectDojoScanName(String securityTestName) {
225226
if (scannerDefectDojoMapping.containsKey(securityTestName)) {
226227
return scannerDefectDojoMapping.get(securityTestName);
227228
}else{
228-
//For non supported scanner
229229
return "Generic Findings Import";
230230
}
231231
}

scb-persistenceproviders/defectdojo-persistenceprovider/src/test/java/io/securecodebox/persistence/DefectDojoPersistenceProviderTest.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -201,7 +201,7 @@ public void createsFindingsForSupportedScanner() throws JsonProcessingException
201201
}
202202

203203
@Test
204-
public void createsFindingsForNonSupportedScanner() throws JsonProcessingException {
204+
public void createsFindingsForNonSupportedScanner() {
205205
SecurityTest securityTest = new SecurityTest();
206206
securityTest.setContext("Non supported Scan 11");
207207
securityTest.setName("any non supported scanner");

0 commit comments

Comments
 (0)