added Test for generic import

Author: Daniel Patanin

scb-engine/src/main/resources/application-dev.yaml

@@ -15,5 +15,5 @@ securecodebox.rest.user.scanner-default:
   password: scan
 
 securecodebox.persistence.defectdojo.baseurl: http://localhost:8000
-securecodebox.persistence.defectdojo.apikey: 
+securecodebox.persistence.defectdojo.apikey: 6fd1b5e90d7afa33d1da939d7d51a9b745b11660
 

scb-persistenceproviders/defectdojo-persistenceprovider/src/test/java/io/securecodebox/persistence/DefectDojoPersistenceProviderTest.java

@@ -2,6 +2,7 @@
 
 import com.fasterxml.jackson.core.JsonProcessingException;
 import com.fasterxml.jackson.databind.ObjectMapper;
+import io.securecodebox.model.findings.Finding;
 import io.securecodebox.model.rest.Report;
 import io.securecodebox.model.securitytest.CommonMetaFields;
 import io.securecodebox.model.securitytest.SecurityTest;
@@ -22,6 +23,7 @@
 import java.time.ZoneId;
 import java.util.*;
 
+import static io.securecodebox.model.findings.Severity.INFORMATIONAL;
 import static org.mockito.Matchers.any;
 import static org.mockito.Matchers.eq;
 import static org.mockito.Mockito.times;
@@ -173,7 +175,7 @@ public void failsIfProductCouldNotBeFound(){
     }
 
     @Test
-    public void createsFindings() throws JsonProcessingException {
+    public void createsFindingsForSupportedScanner() throws JsonProcessingException {
         SecurityTest securityTest = new SecurityTest();
         securityTest.setContext("Nmap Scan 11");
         securityTest.setName("nmap");
@@ -197,4 +199,34 @@ public void createsFindings() throws JsonProcessingException {
                 eq("Nmap Scan")
         );
     }
+
+    @Test
+    public void createsFindingsForNonSupportedScanner() throws JsonProcessingException {
+        SecurityTest securityTest = new SecurityTest();
+        securityTest.setContext("Non supported Scan 11");
+        securityTest.setName("any non supported scanner");
+
+        List<Finding> findings = new ArrayList<>();
+        Finding finding = new Finding();
+        finding.setName("findingname");
+        finding.setDescription("description");
+        finding.setFalsePositive(false);
+        finding.setLocation("http://someadress");
+        finding.setSeverity(INFORMATIONAL);
+        findings.add(finding);
+
+        report.setFindings(findings);
+        securityTest.setMetaData(metaData);
+        securityTest.setReport(report);
+
+        persistenceProvider.persist(securityTest);
+        verify(defectDojoService, times(1)).createFindings(
+                eq( "date,title,cweid,url,severity,description,mitigation,impact,references,active,verified,falsepositive,duplicate\n"+
+                        "2019-01-07,findingname,,http://someadress,INFORMATIONAL,description,,,,,,false,false"),
+                eq("http://localhost:8000/api/v2/engagements/2/"),
+                eq("http://localhost:8000/api/v2/users/5/"),
+                eq("2019-01-07"),
+                eq("Generic Findings Import")
+        );
+    }
 }