Skip to content

Add method to script editor websocket that lists scripts available for subscription#5182

Merged
marchcat merged 4 commits intosecondlife:project/lua_editorfrom
WolfGangS:wolfgang/lua_editor/ws_script_list
Jan 8, 2026
Merged

Add method to script editor websocket that lists scripts available for subscription#5182
marchcat merged 4 commits intosecondlife:project/lua_editorfrom
WolfGangS:wolfgang/lua_editor/ws_script_list

Conversation

@WolfGangS
Copy link
Copy Markdown
Contributor

@WolfGangS WolfGangS commented Dec 21, 2025

Description

Adds a method for the web socket server to allow 3rd party tools to query scripts available for subscription. Useful for the sl-vscode-plugin to be able to resubscribe after a connection loss (like the user updated vscode, or similar)

Also useful for plans to add support for a cli version of the plugin, to allow broader editor compatibility.

Related Issues

Issue Link: relates to secondlife/sl-vscode-plugin#43


Checklist

Please ensure the following before requesting review:

  • I have provided a clear title and detailed description for this pull request.
  • If useful, I have included media such as screenshots and video to show off my changes.
  • The PR is linked to a relevant issue with sufficient context.
  • I have tested the changes locally and verified they work as intended.
  • All new and existing tests pass.
  • Code follows the project's style guidelines.
  • Documentation has been updated if needed.
  • Any dependent changes have been merged and published in downstream modules
  • I have reviewed the contributing guidelines.

Additional Notes

Discussed with @Rider-Linden before, so likely more his wheelhouse for review.

I suspect there may be some issue I am missing with my changes to LLScriptEditorWSServer::unsubscribeConnection but they (or something like them) are needed else a websocket connection closing flushes scripts from the subscription list, even though they are still open in viewer, and on disk in the temp directory.

…ubscription

Signed-off-by: WolfGangS <flamin2k8@gmail.com>
Signed-off-by: WolfGangS <flamin2k8@gmail.com>
@akleshchev akleshchev requested a review from marchcat January 6, 2026 16:33
Copy link
Copy Markdown
Contributor

@marchcat marchcat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

Signed-off-by: WolfGangS <flamin2k8@gmail.com>
Comment thread indra/newview/llscripteditorws.cpp Outdated
Copy link
Copy Markdown
Contributor

@Rider-Linden Rider-Linden left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just Marchcat's change and the script unsubscribe list thing.

Comment thread indra/newview/llscripteditorws.cpp
Copy link
Copy Markdown
Contributor

@Rider-Linden Rider-Linden left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good to go.

Co-authored-by: Andrey Lihatskiy <118752495+marchcat@users.noreply.github.com>
@marchcat marchcat merged commit 0d846fe into secondlife:project/lua_editor Jan 8, 2026
11 checks passed
@github-actions github-actions Bot locked and limited conversation to collaborators Jan 8, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants