Add method to script editor websocket that lists scripts available for subscription#5182
Merged
marchcat merged 4 commits intosecondlife:project/lua_editorfrom Jan 8, 2026
Conversation
…ubscription Signed-off-by: WolfGangS <flamin2k8@gmail.com>
Signed-off-by: WolfGangS <flamin2k8@gmail.com>
Signed-off-by: WolfGangS <flamin2k8@gmail.com>
marchcat
reviewed
Jan 7, 2026
Rider-Linden
requested changes
Jan 7, 2026
Contributor
Rider-Linden
left a comment
There was a problem hiding this comment.
Just Marchcat's change and the script unsubscribe list thing.
Co-authored-by: Andrey Lihatskiy <118752495+marchcat@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Adds a method for the web socket server to allow 3rd party tools to query scripts available for subscription. Useful for the sl-vscode-plugin to be able to resubscribe after a connection loss (like the user updated vscode, or similar)
Also useful for plans to add support for a cli version of the plugin, to allow broader editor compatibility.
Related Issues
Issue Link: relates to secondlife/sl-vscode-plugin#43
Checklist
Please ensure the following before requesting review:
Additional Notes
Discussed with @Rider-Linden before, so likely more his wheelhouse for review.
I suspect there may be some issue I am missing with my changes to
LLScriptEditorWSServer::unsubscribeConnectionbut they (or something like them) are needed else a websocket connection closing flushes scripts from the subscription list, even though they are still open in viewer, and on disk in the temp directory.